Skip to content

Fix Exception Replay in Lambda #8849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nhulston wants to merge 6 commits into from
Closed

Fix Exception Replay in Lambda #8849

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c4a17c6
add fallback for lambda
nhulston May 19, 2025
a60af39
unit test
nhulston May 19, 2025
03689f9
mock exception to return truncated stack like Lambda
nhulston May 20, 2025
130556a
Merge branch 'master' into nicholas.hulston/fix-exception-replay-in-l…
nhulston May 20, 2025
a968384
Merge branch 'master' into nicholas.hulston/fix-exception-replay-in-l…
nhulston May 20, 2025
1f12c25
Merge branch 'master' into nicholas.hulston/fix-exception-replay-in-l…
nhulston May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add fallback for lambda
  • Loading branch information
@nhulston
nhulston committed May 19, 2025
commit c4a17c62c2511f47ebe0d36d1f0f14d0b03d8da1
7 changes: 7 additions & 0 deletions ...agent-debugger/src/main/java/com/datadog/debugger/exception/DefaultExceptionDebugger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,13 @@ private static void processSnapshotsAndSetTags(
int[] mapping = createThrowableMapping(currentEx, t);
StackTraceElement[] innerTrace = currentEx.getStackTrace();
int currentIdx = innerTrace.length - snapshot.getStack().size();

if (currentIdx < 0) {
// This means the innerTrace was truncated by the underlying environment.
// This is known to happen in AWS Lambda, but may also happen elsewhere.
currentIdx = i;
}

if (!sanityCheckSnapshotAssignment(snapshot, innerTrace, currentIdx)) {
continue;
}
Expand Down