Skip to content

Exclude jackson afterburner dynamic classes from instrumentation #8747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amarziali merged 2 commits into from
Apr 29, 2025
Merged

Exclude jackson afterburner dynamic classes from instrumentation #8747

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d997343
Exclude jackson afterburner dynamic classes from instrumentation
amarziali Apr 29, 2025
60a1d58
add hibernate gen classes exclusions
amarziali Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ain/resources/datadog/trace/agent/tooling/bytebuddy/matcher/proxy_ignored_class_name.trie
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,8 @@
1 $$_Weld*
1 $$_jvst*
1 $$SpringCGLIB$$*
# Jackson afterburner
1 $Access4JacksonDeserializer*
1 $Access4JacksonSerializer*
1 $Creator4JacksonDeserializer*
1 $Creator4JacksonSerializer*
Copy link
Copy Markdown
Contributor

@bric3 bric3 Apr 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: There's no $Creator4JacksonSerializer ;)

Also, there are possibly these hibernate ones:

  • $HibernateInstantiator$
  • $HibernateProxy$
  • $HibernateAccessOptimizer$

see #8678 (comment) and #8678 (comment)

On another note, we wondered if we wanted to have a toggle for these classes (Maybe added as another trie ?).

Copy link
Copy Markdown
Contributor

@mcculls mcculls Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On another note, we wondered if we wanted to have a toggle for these classes (Maybe added as another trie ?).

Rather than introduce another trie, you could take the same approach as in ignored_class_name.trie and use a different number for ignores that can be toggled

i.e. 0 == force allow, 1 == force ignore, 2 == optional ignore, etc...

You could have as many extra values as you want for different categories

Copy link
Copy Markdown
Contributor Author

@amarziali amarziali Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes as @mcculls proposes there is no need to add another trie but just having a different result.
Thanks @bric3 for the note :) let me remove the exceeding one and add the hibernate ones. Did you have a precise use case for having different trie result values?