More ForkJoin instrumentations - #672
Merged
Merged
Conversation
mar-kolya
force-pushed
the
mar-kolya/more-forkjoin-instrumentations
branch
4 times, most recently
from
January 25, 2019 19:45
09d93f6 to
e35066a
Compare
mar-kolya
force-pushed
the
mar-kolya/more-forkjoin-instrumentations
branch
4 times, most recently
from
January 25, 2019 20:45
119ce2e to
f98e582
Compare
mar-kolya
force-pushed
the
mar-kolya/more-forkjoin-instrumentations
branch
from
January 25, 2019 21:01
f98e582 to
7fec326
Compare
mar-kolya
force-pushed
the
mar-kolya/more-forkjoin-instrumentations
branch
from
January 25, 2019 21:15
7fec326 to
f7844f7
Compare
tylerbenson
approved these changes
Jan 28, 2019
| static final String TASK_CLASS_NAME = "akka.dispatch.forkjoin.ForkJoinTask"; | ||
|
|
||
| public AkkaForkJoinTaskInstrumentation() { | ||
| super(AbstractExecutorInstrumentation.EXEC_NAME); |
Contributor
There was a problem hiding this comment.
I think it would be good to have an alternate name for each of these that can be possibly disabled independently in case we end up over-instrumenting and want to disable only this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add special implementations for Scala and Akka
ForkJoinPoolandForkJoinTask. These are essentially copy-pastes from JVM implementation, but we have to instrument them separately.