Change Spring Security ownership to ASM by smola · Pull Request #6279 · DataDog/dd-trace-java

smola · 2023-11-27T10:18:45Z

What Does This Do

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

pr-commenter · 2023-11-27T11:01:24Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	smola/spring-security-ownership
git_commit_date	1701079687	1701080290
git_commit_sha	`0b39312`	`ea57ecf`
release_version	1.25.0-SNAPSHOT~0b39312601	1.25.0-SNAPSHOT~ea57ecfb6d

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1701082841	1701082841
ci_job_id	376331035	376331035
ci_pipeline_id	23814236	23814236
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 10 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.25.0-SNAPSHOT~ea57ecfb6d, baseline=1.25.0-SNAPSHOT~0b39312601

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045886
Total [baseline] (9.349 s) : 0, 9349053
Agent [candidate] (1.034 s) : 0, 1034352
Total [candidate] (9.288 s) : 0, 9288255
section appsec
Agent [baseline] (1.119 s) : 0, 1118936
Total [baseline] (9.428 s) : 0, 9427775
Agent [candidate] (1.12 s) : 0, 1120435
Total [candidate] (9.375 s) : 0, 9374595
section iast
Agent [baseline] (1.153 s) : 0, 1153335
Total [baseline] (9.581 s) : 0, 9581297
Agent [candidate] (1.154 s) : 0, 1154116
Total [candidate] (9.658 s) : 0, 9658150
section profiling
Agent [baseline] (1.224 s) : 0, 1224042
Total [baseline] (9.592 s) : 0, 9591702
Agent [candidate] (1.232 s) : 0, 1232033
Total [candidate] (9.669 s) : 0, 9668888

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	appsec	1.119 s	73.051 ms (7.0%)
Agent	iast	1.153 s	107.449 ms (10.3%)
Agent	profiling	1.224 s	178.156 ms (17.0%)
Total	tracing	9.349 s	-
Total	appsec	9.428 s	78.721 ms (0.8%)
Total	iast	9.581 s	232.243 ms (2.5%)
Total	profiling	9.592 s	242.648 ms (2.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.034 s	-
Agent	appsec	1.12 s	86.083 ms (8.3%)
Agent	iast	1.154 s	119.764 ms (11.6%)
Agent	profiling	1.232 s	197.681 ms (19.1%)
Total	tracing	9.288 s	-
Total	appsec	9.375 s	86.34 ms (0.9%)
Total	iast	9.658 s	369.895 ms (4.0%)
Total	profiling	9.669 s	380.633 ms (4.1%)

gantt
    title petclinic - break down per module: candidate=1.25.0-SNAPSHOT~ea57ecfb6d, baseline=1.25.0-SNAPSHOT~0b39312601

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (653.026 ms) : 0, 653026
BytebuddyAgent [candidate] (645.054 ms) : 0, 645054
GlobalTracer [baseline] (301.184 ms) : 0, 301184
GlobalTracer [candidate] (298.566 ms) : 0, 298566
AppSec [baseline] (48.915 ms) : 0, 48915
AppSec [candidate] (48.385 ms) : 0, 48385
Remote Config [baseline] (697.56 µs) : 0, 698
Remote Config [candidate] (684.919 µs) : 0, 685
Telemetry [baseline] (7.37 ms) : 0, 7370
Telemetry [candidate] (7.342 ms) : 0, 7342
section appsec
BytebuddyAgent [baseline] (644.174 ms) : 0, 644174
BytebuddyAgent [candidate] (644.498 ms) : 0, 644498
GlobalTracer [baseline] (296.8 ms) : 0, 296800
GlobalTracer [candidate] (298.121 ms) : 0, 298121
AppSec [baseline] (136.326 ms) : 0, 136326
AppSec [candidate] (136.237 ms) : 0, 136237
Remote Config [baseline] (639.677 µs) : 0, 640
Remote Config [candidate] (640.653 µs) : 0, 641
Telemetry [baseline] (6.743 ms) : 0, 6743
Telemetry [candidate] (6.75 ms) : 0, 6750
section iast
BytebuddyAgent [baseline] (765.406 ms) : 0, 765406
BytebuddyAgent [candidate] (766.508 ms) : 0, 766508
GlobalTracer [baseline] (278.577 ms) : 0, 278577
GlobalTracer [candidate] (279.218 ms) : 0, 279218
AppSec [baseline] (47.531 ms) : 0, 47531
AppSec [candidate] (49.98 ms) : 0, 49980
IAST [baseline] (16.071 ms) : 0, 16071
IAST [candidate] (14.01 ms) : 0, 14010
Remote Config [baseline] (578.687 µs) : 0, 579
Remote Config [candidate] (571.806 µs) : 0, 572
Telemetry [baseline] (10.861 ms) : 0, 10861
Telemetry [candidate] (9.405 ms) : 0, 9405
section profiling
BytebuddyAgent [baseline] (654.382 ms) : 0, 654382
BytebuddyAgent [candidate] (661.142 ms) : 0, 661142
GlobalTracer [baseline] (370.083 ms) : 0, 370083
GlobalTracer [candidate] (370.683 ms) : 0, 370683
AppSec [baseline] (48.965 ms) : 0, 48965
AppSec [candidate] (49.033 ms) : 0, 49033
Remote Config [baseline] (699.297 µs) : 0, 699
Remote Config [candidate] (707.039 µs) : 0, 707
Telemetry [baseline] (7.426 ms) : 0, 7426
Telemetry [candidate] (7.42 ms) : 0, 7420
ProfilingAgent [baseline] (88.629 ms) : 0, 88629
ProfilingAgent [candidate] (88.525 ms) : 0, 88525
Profiling [baseline] (88.653 ms) : 0, 88653
Profiling [candidate] (88.548 ms) : 0, 88548

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.25.0-SNAPSHOT~ea57ecfb6d, baseline=1.25.0-SNAPSHOT~0b39312601

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1028765
Total [baseline] (8.664 s) : 0, 8663735
Agent [candidate] (1.035 s) : 0, 1034743
Total [candidate] (8.669 s) : 0, 8668906
section iast
Agent [baseline] (1.153 s) : 0, 1152946
Total [baseline] (9.268 s) : 0, 9268346
Agent [candidate] (1.153 s) : 0, 1153292
Total [candidate] (9.276 s) : 0, 9276390
section iast_TELEMETRY_OFF
Agent [baseline] (1.143 s) : 0, 1142609
Total [baseline] (9.197 s) : 0, 9197252
Agent [candidate] (1.143 s) : 0, 1142514
Total [candidate] (9.192 s) : 0, 9192133

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.029 s	-
Agent	iast	1.153 s	124.18 ms (12.1%)
Agent	iast_TELEMETRY_OFF	1.143 s	113.843 ms (11.1%)
Total	tracing	8.664 s	-
Total	iast	9.268 s	604.611 ms (7.0%)
Total	iast_TELEMETRY_OFF	9.197 s	533.517 ms (6.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.035 s	-
Agent	iast	1.153 s	118.549 ms (11.5%)
Agent	iast_TELEMETRY_OFF	1.143 s	107.772 ms (10.4%)
Total	tracing	8.669 s	-
Total	iast	9.276 s	607.484 ms (7.0%)
Total	iast_TELEMETRY_OFF	9.192 s	523.227 ms (6.0%)

gantt
    title insecure-bank - break down per module: candidate=1.25.0-SNAPSHOT~ea57ecfb6d, baseline=1.25.0-SNAPSHOT~0b39312601

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (642.018 ms) : 0, 642018
BytebuddyAgent [candidate] (645.611 ms) : 0, 645611
GlobalTracer [baseline] (296.445 ms) : 0, 296445
GlobalTracer [candidate] (298.773 ms) : 0, 298773
AppSec [baseline] (48.199 ms) : 0, 48199
AppSec [candidate] (48.172 ms) : 0, 48172
Remote Config [baseline] (687.276 µs) : 0, 687
Remote Config [candidate] (680.597 µs) : 0, 681
Telemetry [baseline] (7.254 ms) : 0, 7254
Telemetry [candidate] (7.285 ms) : 0, 7285
section iast
BytebuddyAgent [baseline] (765.558 ms) : 0, 765558
BytebuddyAgent [candidate] (766.358 ms) : 0, 766358
GlobalTracer [baseline] (278.434 ms) : 0, 278434
GlobalTracer [candidate] (278.164 ms) : 0, 278164
AppSec [baseline] (48.608 ms) : 0, 48608
AppSec [candidate] (47.408 ms) : 0, 47408
IAST [baseline] (16.076 ms) : 0, 16076
IAST [candidate] (15.437 ms) : 0, 15437
Remote Config [baseline] (575.592 µs) : 0, 576
Remote Config [candidate] (582.11 µs) : 0, 582
Telemetry [baseline] (9.365 ms) : 0, 9365
Telemetry [candidate] (10.988 ms) : 0, 10988
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (756.981 ms) : 0, 756981
BytebuddyAgent [candidate] (756.308 ms) : 0, 756308
GlobalTracer [baseline] (277.593 ms) : 0, 277593
GlobalTracer [candidate] (278.721 ms) : 0, 278721
AppSec [baseline] (46.74 ms) : 0, 46740
AppSec [candidate] (46.982 ms) : 0, 46982
IAST [baseline] (19.368 ms) : 0, 19368
IAST [candidate] (17.911 ms) : 0, 17911
Remote Config [baseline] (545.334 µs) : 0, 545
Remote Config [candidate] (562.311 µs) : 0, 562
Telemetry [baseline] (7.063 ms) : 0, 7063
Telemetry [candidate] (7.762 ms) : 0, 7762

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2023-11-27T10:39:55	2023-11-27T10:56:28
git_branch	master	smola/spring-security-ownership
git_commit_date	1701079687	1701080290
git_commit_sha	`0b39312`	`ea57ecf`
release_version	1.25.0-SNAPSHOT~0b39312601	1.25.0-SNAPSHOT~ea57ecfb6d
start_time	2023-11-27T10:39:42	2023-11-27T10:56:15

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1701082841	1701082841
ci_job_id	376331035	376331035
ci_pipeline_id	23814236	23814236
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 13 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.25.0-SNAPSHOT~ea57ecfb6d, baseline=1.25.0-SNAPSHOT~0b39312601
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.358 ms) : 1339, 1377
.   : milestone, 1358,
appsec (1.746 ms) : 1720, 1771
.   : milestone, 1746,
iast (1.542 ms) : 1518, 1566
.   : milestone, 1542,
profiling (1.533 ms) : 1507, 1560
.   : milestone, 1533,
tracing (1.523 ms) : 1498, 1547
.   : milestone, 1523,
section candidate
no_agent (1.375 ms) : 1356, 1394
.   : milestone, 1375,
appsec (1.77 ms) : 1744, 1795
.   : milestone, 1770,
iast (1.53 ms) : 1506, 1554
.   : milestone, 1530,
profiling (1.51 ms) : 1485, 1536
.   : milestone, 1510,
tracing (1.513 ms) : 1488, 1537
.   : milestone, 1513,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.358 ms [1.339 ms, 1.377 ms]	-
appsec	1.746 ms [1.72 ms, 1.771 ms]	387.53 µs (28.5%)
iast	1.542 ms [1.518 ms, 1.566 ms]	183.628 µs (13.5%)
profiling	1.533 ms [1.507 ms, 1.56 ms]	175.407 µs (12.9%)
tracing	1.523 ms [1.498 ms, 1.547 ms]	164.71 µs (12.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.375 ms [1.356 ms, 1.394 ms]	-
appsec	1.77 ms [1.744 ms, 1.795 ms]	395.126 µs (28.7%)
iast	1.53 ms [1.506 ms, 1.554 ms]	155.439 µs (11.3%)
profiling	1.51 ms [1.485 ms, 1.536 ms]	135.7 µs (9.9%)
tracing	1.513 ms [1.488 ms, 1.537 ms]	137.792 µs (10.0%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.25.0-SNAPSHOT~ea57ecfb6d, baseline=1.25.0-SNAPSHOT~0b39312601
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.332 µs) : 346, 386
.   : milestone, 366,
iast (473.257 µs) : 453, 494
.   : milestone, 473,
iast_FULL (533.835 µs) : 513, 554
.   : milestone, 534,
iast_INACTIVE (447.753 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (475.047 µs) : 454, 496
.   : milestone, 475,
tracing (451.04 µs) : 430, 472
.   : milestone, 451,
section candidate
no_agent (364.212 µs) : 345, 384
.   : milestone, 364,
iast (473.895 µs) : 453, 495
.   : milestone, 474,
iast_FULL (537.57 µs) : 517, 558
.   : milestone, 538,
iast_INACTIVE (446.032 µs) : 425, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (467.604 µs) : 447, 488
.   : milestone, 468,
tracing (447.986 µs) : 427, 469
.   : milestone, 448,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	366.332 µs [346.256 µs, 386.407 µs]	-
iast	473.257 µs [452.912 µs, 493.601 µs]	106.925 µs (29.2%)
iast_FULL	533.835 µs [513.448 µs, 554.222 µs]	167.503 µs (45.7%)
iast_INACTIVE	447.753 µs [426.977 µs, 468.529 µs]	81.421 µs (22.2%)
iast_TELEMETRY_OFF	475.047 µs [453.751 µs, 496.342 µs]	108.715 µs (29.7%)
tracing	451.04 µs [429.915 µs, 472.166 µs]	84.709 µs (23.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	364.212 µs [344.56 µs, 383.863 µs]	-
iast	473.895 µs [453.071 µs, 494.72 µs]	109.684 µs (30.1%)
iast_FULL	537.57 µs [517.102 µs, 558.039 µs]	173.359 µs (47.6%)
iast_INACTIVE	446.032 µs [425.134 µs, 466.931 µs]	81.821 µs (22.5%)
iast_TELEMETRY_OFF	467.604 µs [446.856 µs, 488.352 µs]	103.393 µs (28.4%)
tracing	447.986 µs [427.236 µs, 468.736 µs]	83.775 µs (23.0%)

Change Spring Security ownership to ASM

ea57ecf

smola added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Nov 27, 2023

smola requested a review from a team November 27, 2023 10:18

smola requested a review from a team as a code owner November 27, 2023 10:18

smola requested review from mcculls and ygree November 27, 2023 10:18

amarziali approved these changes Nov 27, 2023

View reviewed changes

smola requested review from a team, ValentinZakharov and jandro996 and removed request for a team November 27, 2023 17:51

smola merged commit 4a83401 into master Nov 28, 2023

smola deleted the smola/spring-security-ownership branch November 28, 2023 07:57

github-actions Bot added this to the 1.25.0 milestone Nov 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change Spring Security ownership to ASM#6279

Change Spring Security ownership to ASM#6279
smola merged 1 commit into
masterfrom
smola/spring-security-ownership

smola commented Nov 27, 2023

Uh oh!

pr-commenter Bot commented Nov 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

smola commented Nov 27, 2023

What Does This Do

Motivation

Additional Notes

Uh oh!

pr-commenter Bot commented Nov 27, 2023

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants