Skip to content

Spring scheduling: have actuator display the right task class name#6249

Merged
amarziali merged 1 commit into
masterfrom
andrea.marziali/spring-scheduler-naming
Nov 27, 2023
Merged

Spring scheduling: have actuator display the right task class name#6249
amarziali merged 1 commit into
masterfrom
andrea.marziali/spring-scheduler-naming

Conversation

@amarziali
Copy link
Copy Markdown
Contributor

@amarziali amarziali commented Nov 20, 2023 •
edited
Loading

What Does This Do

Solves #5651

Motivation

Additional Notes

Also add tests for spring 6

@amarziali amarziali requested a review from a team as a code owner November 20, 2023 14:17
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Nov 20, 2023 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/spring-scheduler-naming
git_commit_date 1701092421 1701093528
git_commit_sha acd82c6 25a40cf
release_version 1.25.0-SNAPSHOT~acd82c6fad 1.25.0-SNAPSHOT~25a40cf865
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1701096228 1701096228
ci_job_id 376446661 376446661
ci_pipeline_id 23821825 23821825
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 9 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.25.0-SNAPSHOT~25a40cf865, baseline=1.25.0-SNAPSHOT~acd82c6fad

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.031 s) : 0, 1031102
Total [baseline] (9.26 s) : 0, 9259627
Agent [candidate] (1.033 s) : 0, 1032786
Total [candidate] (9.302 s) : 0, 9302298
section appsec
Agent [baseline] (1.119 s) : 0, 1118906
Total [baseline] (9.388 s) : 0, 9387585
Agent [candidate] (1.136 s) : 0, 1135766
Total [candidate] (9.513 s) : 0, 9513397
section iast
Agent [baseline] (1.154 s) : 0, 1153917
Total [baseline] (9.589 s) : 0, 9589210
Agent [candidate] (1.153 s) : 0, 1152771
Total [candidate] (9.552 s) : 0, 9551827
section profiling
Agent [baseline] (1.223 s) : 0, 1222618
Total [baseline] (9.643 s) : 0, 9642952
Agent [candidate] (1.221 s) : 0, 1221287
Total [candidate] (9.632 s) : 0, 9632412
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.031 s -
Agent appsec 1.119 s 87.804 ms (8.5%)
Agent iast 1.154 s 122.815 ms (11.9%)
Agent profiling 1.223 s 191.516 ms (18.6%)
Total tracing 9.26 s -
Total appsec 9.388 s 127.958 ms (1.4%)
Total iast 9.589 s 329.583 ms (3.6%)
Total profiling 9.643 s 383.325 ms (4.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.033 s -
Agent appsec 1.136 s 102.98 ms (10.0%)
Agent iast 1.153 s 119.985 ms (11.6%)
Agent profiling 1.221 s 188.501 ms (18.3%)
Total tracing 9.302 s -
Total appsec 9.513 s 211.098 ms (2.3%)
Total iast 9.552 s 249.529 ms (2.7%)
Total profiling 9.632 s 330.114 ms (3.5%) 
gantt
    title petclinic - break down per module: candidate=1.25.0-SNAPSHOT~25a40cf865, baseline=1.25.0-SNAPSHOT~acd82c6fad

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (643.568 ms) : 0, 643568
BytebuddyAgent [candidate] (644.201 ms) : 0, 644201
GlobalTracer [baseline] (297.352 ms) : 0, 297352
GlobalTracer [candidate] (297.716 ms) : 0, 297716
AppSec [baseline] (48.128 ms) : 0, 48128
AppSec [candidate] (48.745 ms) : 0, 48745
Remote Config [baseline] (673.346 µs) : 0, 673
Remote Config [candidate] (685.982 µs) : 0, 686
Telemetry [baseline] (7.226 ms) : 0, 7226
Telemetry [candidate] (7.263 ms) : 0, 7263
section appsec
BytebuddyAgent [baseline] (643.52 ms) : 0, 643520
BytebuddyAgent [candidate] (653.309 ms) : 0, 653309
GlobalTracer [baseline] (297.396 ms) : 0, 297396
GlobalTracer [candidate] (302.672 ms) : 0, 302672
AppSec [baseline] (136.319 ms) : 0, 136319
AppSec [candidate] (137.53 ms) : 0, 137530
Remote Config [baseline] (638.556 µs) : 0, 639
Remote Config [candidate] (651.205 µs) : 0, 651
Telemetry [baseline] (6.759 ms) : 0, 6759
Telemetry [candidate] (6.89 ms) : 0, 6890
section iast
BytebuddyAgent [baseline] (765.669 ms) : 0, 765669
BytebuddyAgent [candidate] (764.924 ms) : 0, 764924
GlobalTracer [baseline] (278.98 ms) : 0, 278980
GlobalTracer [candidate] (278.608 ms) : 0, 278608
AppSec [baseline] (48.843 ms) : 0, 48843
AppSec [candidate] (49.394 ms) : 0, 49394
IAST [baseline] (16.181 ms) : 0, 16181
IAST [candidate] (16.232 ms) : 0, 16232
Remote Config [baseline] (571.073 µs) : 0, 571
Remote Config [candidate] (577.802 µs) : 0, 578
Telemetry [baseline] (9.374 ms) : 0, 9374
Telemetry [candidate] (8.772 ms) : 0, 8772
section profiling
BytebuddyAgent [baseline] (655.011 ms) : 0, 655011
BytebuddyAgent [candidate] (654.355 ms) : 0, 654355
GlobalTracer [baseline] (368.894 ms) : 0, 368894
GlobalTracer [candidate] (368.301 ms) : 0, 368301
AppSec [baseline] (48.449 ms) : 0, 48449
AppSec [candidate] (48.317 ms) : 0, 48317
Remote Config [baseline] (716.02 µs) : 0, 716
Remote Config [candidate] (699.659 µs) : 0, 700
Telemetry [baseline] (7.42 ms) : 0, 7420
Telemetry [candidate] (7.379 ms) : 0, 7379
ProfilingAgent [baseline] (88.102 ms) : 0, 88102
ProfilingAgent [candidate] (88.25 ms) : 0, 88250
Profiling [baseline] (88.125 ms) : 0, 88125
Profiling [candidate] (88.274 ms) : 0, 88274
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.25.0-SNAPSHOT~25a40cf865, baseline=1.25.0-SNAPSHOT~acd82c6fad

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.033 s) : 0, 1032987
Total [baseline] (8.676 s) : 0, 8676118
Agent [candidate] (1.041 s) : 0, 1040720
Total [candidate] (8.731 s) : 0, 8730753
section iast
Agent [baseline] (1.158 s) : 0, 1157724
Total [baseline] (9.255 s) : 0, 9254520
Agent [candidate] (1.161 s) : 0, 1160864
Total [candidate] (9.243 s) : 0, 9242574
section iast_TELEMETRY_OFF
Agent [baseline] (1.145 s) : 0, 1144614
Total [baseline] (9.23 s) : 0, 9230185
Agent [candidate] (1.151 s) : 0, 1151446
Total [candidate] (9.219 s) : 0, 9218625
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.033 s -
Agent iast 1.158 s 124.737 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.145 s 111.627 ms (10.8%)
Total tracing 8.676 s -
Total iast 9.255 s 578.402 ms (6.7%)
Total iast_TELEMETRY_OFF 9.23 s 554.067 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent iast 1.161 s 120.144 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.151 s 110.725 ms (10.6%)
Total tracing 8.731 s -
Total iast 9.243 s 511.822 ms (5.9%)
Total iast_TELEMETRY_OFF 9.219 s 487.873 ms (5.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.25.0-SNAPSHOT~25a40cf865, baseline=1.25.0-SNAPSHOT~acd82c6fad

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (644.641 ms) : 0, 644641
BytebuddyAgent [candidate] (649.072 ms) : 0, 649072
GlobalTracer [baseline] (297.718 ms) : 0, 297718
GlobalTracer [candidate] (300.486 ms) : 0, 300486
AppSec [baseline] (48.438 ms) : 0, 48438
AppSec [candidate] (48.692 ms) : 0, 48692
Remote Config [baseline] (678.483 µs) : 0, 678
Remote Config [candidate] (691.721 µs) : 0, 692
Telemetry [baseline] (7.271 ms) : 0, 7271
Telemetry [candidate] (7.3 ms) : 0, 7300
section iast
BytebuddyAgent [baseline] (769.027 ms) : 0, 769027
BytebuddyAgent [candidate] (770.488 ms) : 0, 770488
GlobalTracer [baseline] (279.508 ms) : 0, 279508
GlobalTracer [candidate] (280.347 ms) : 0, 280347
AppSec [baseline] (47.813 ms) : 0, 47813
AppSec [candidate] (50.617 ms) : 0, 50617
IAST [baseline] (17.668 ms) : 0, 17668
IAST [candidate] (15.558 ms) : 0, 15558
Remote Config [baseline] (571.292 µs) : 0, 571
Remote Config [candidate] (574.456 µs) : 0, 574
Telemetry [baseline] (8.674 ms) : 0, 8674
Telemetry [candidate] (8.68 ms) : 0, 8680
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (757.742 ms) : 0, 757742
BytebuddyAgent [candidate] (764.391 ms) : 0, 764391
GlobalTracer [baseline] (278.442 ms) : 0, 278442
GlobalTracer [candidate] (280.57 ms) : 0, 280570
AppSec [baseline] (46.965 ms) : 0, 46965
AppSec [candidate] (46.734 ms) : 0, 46734
IAST [baseline] (17.964 ms) : 0, 17964
IAST [candidate] (16.725 ms) : 0, 16725
Remote Config [baseline] (559.299 µs) : 0, 559
Remote Config [candidate] (561.131 µs) : 0, 561
Telemetry [baseline] (8.54 ms) : 0, 8540
Telemetry [candidate] (7.883 ms) : 0, 7883
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2023-11-27T14:23:05 2023-11-27T14:39:36
git_branch master andrea.marziali/spring-scheduler-naming
git_commit_date 1701092421 1701093528
git_commit_sha acd82c6 25a40cf
release_version 1.25.0-SNAPSHOT~acd82c6fad 1.25.0-SNAPSHOT~25a40cf865
start_time 2023-11-27T14:22:52 2023-11-27T14:39:23
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1701096228 1701096228
ci_job_id 376446661 376446661
ci_pipeline_id 23821825 23821825
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 14 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.25.0-SNAPSHOT~25a40cf865, baseline=1.25.0-SNAPSHOT~acd82c6fad
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.337 ms) : 1319, 1356
.   : milestone, 1337,
appsec (1.739 ms) : 1714, 1764
.   : milestone, 1739,
iast (1.53 ms) : 1505, 1554
.   : milestone, 1530,
profiling (1.508 ms) : 1483, 1533
.   : milestone, 1508,
tracing (1.512 ms) : 1487, 1537
.   : milestone, 1512,
section candidate
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.778 ms) : 1752, 1803
.   : milestone, 1778,
iast (1.508 ms) : 1483, 1533
.   : milestone, 1508,
profiling (1.501 ms) : 1476, 1526
.   : milestone, 1501,
tracing (1.488 ms) : 1464, 1513
.   : milestone, 1488,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.319 ms, 1.356 ms] -
appsec 1.739 ms [1.714 ms, 1.764 ms] 401.792 µs (30.0%)
iast 1.53 ms [1.505 ms, 1.554 ms] 192.142 µs (14.4%)
profiling 1.508 ms [1.483 ms, 1.533 ms] 170.594 µs (12.8%)
tracing 1.512 ms [1.487 ms, 1.537 ms] 174.668 µs (13.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.778 ms [1.752 ms, 1.803 ms] 434.726 µs (32.4%)
iast 1.508 ms [1.483 ms, 1.533 ms] 165.185 µs (12.3%)
profiling 1.501 ms [1.476 ms, 1.526 ms] 158.08 µs (11.8%)
tracing 1.488 ms [1.464 ms, 1.513 ms] 145.428 µs (10.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.25.0-SNAPSHOT~25a40cf865, baseline=1.25.0-SNAPSHOT~acd82c6fad
    dateFormat X
    axisFormat %s
section baseline
no_agent (360.848 µs) : 341, 381
.   : milestone, 361,
iast (464.194 µs) : 444, 485
.   : milestone, 464,
iast_FULL (530.249 µs) : 510, 551
.   : milestone, 530,
iast_INACTIVE (445.255 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (459.421 µs) : 439, 480
.   : milestone, 459,
tracing (432.952 µs) : 413, 453
.   : milestone, 433,
section candidate
no_agent (372.405 µs) : 353, 392
.   : milestone, 372,
iast (467.696 µs) : 447, 488
.   : milestone, 468,
iast_FULL (525.816 µs) : 506, 546
.   : milestone, 526,
iast_INACTIVE (442.315 µs) : 422, 463
.   : milestone, 442,
iast_TELEMETRY_OFF (463.367 µs) : 442, 485
.   : milestone, 463,
tracing (437.59 µs) : 417, 459
.   : milestone, 438,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 360.848 µs [341.059 µs, 380.636 µs] -
iast 464.194 µs [443.831 µs, 484.557 µs] 103.346 µs (28.6%)
iast_FULL 530.249 µs [509.91 µs, 550.588 µs] 169.401 µs (46.9%)
iast_INACTIVE 445.255 µs [424.105 µs, 466.405 µs] 84.408 µs (23.4%)
iast_TELEMETRY_OFF 459.421 µs [438.813 µs, 480.029 µs] 98.573 µs (27.3%)
tracing 432.952 µs [412.695 µs, 453.208 µs] 72.104 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.405 µs [352.587 µs, 392.222 µs] -
iast 467.696 µs [447.27 µs, 488.121 µs] 95.291 µs (25.6%)
iast_FULL 525.816 µs [505.507 µs, 546.124 µs] 153.411 µs (41.2%)
iast_INACTIVE 442.315 µs [421.878 µs, 462.752 µs] 69.91 µs (18.8%)
iast_TELEMETRY_OFF 463.367 µs [442.206 µs, 484.527 µs] 90.962 µs (24.4%)
tracing 437.59 µs [416.633 µs, 458.546 µs] 65.185 µs (17.5%)

@amarziali amarziali force-pushed the andrea.marziali/spring-scheduler-naming branch 2 times, most recently from 7adccdf to 6990f47 Compare November 20, 2023 16:41
@amarziali amarziali added the inst: spring Spring instrumentation label Nov 20, 2023
ygree
ygree reviewed Nov 21, 2023
View reviewed changes
Comment thread dd-java-agent/instrumentation/spring-scheduling-3.1/build.gradle Outdated
ygree
ygree approved these changes Nov 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have one question about Java 17 though.

@amarziali amarziali force-pushed the andrea.marziali/spring-scheduler-naming branch from 6990f47 to 25a40cf Compare November 27, 2023 13:59
@amarziali amarziali changed the title Support spring-scheduling 6 Spring scheduling: have actuator display the right task class name Nov 27, 2023
@amarziali amarziali enabled auto-merge (squash) November 27, 2023 14:01
@amarziali amarziali added the type: bug Bug report and fix label Nov 27, 2023
@amarziali amarziali merged commit 0f2d96f into master Nov 27, 2023
@amarziali amarziali deleted the andrea.marziali/spring-scheduler-naming branch November 27, 2023 14:54
@github-actions github-actions Bot added this to the 1.25.0 milestone Nov 27, 2023
@amarziali amarziali mentioned this pull request Nov 27, 2023
Closed
@amarziali amarziali mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ygree ygree ygree approved these changes

@bantonsson bantonsson Awaiting requested review from bantonsson bantonsson was automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

inst: spring Spring instrumentation type: bug Bug report and fix

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

2 participants

@amarziali @ygree