Simplify Muzzle side-classes to make them easier to unload...#3854
Merged
Conversation
devinsba
approved these changes
Sep 19, 2022
44e032e to
a6a3fe2
Compare
… the need to modify the Instrumenter class
ab704b0 to
cacda6c
Compare
nayeem-kamal
pushed a commit
that referenced
this pull request
Sep 23, 2022
… the need to modify the Instrumenter class (#3854)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...by making them extend
ReferenceMatcherinstead of embedding it as a field. This means theInstrumenterclass can just cast the loadedMuzzleclass and doesn't have to be transformed to add the right bytecode to access the field (as that then pins a reference to theMuzzleclass in theInstrumenters constant pool.