Fix race condition between RC and debugger#3848
Merged
Merged
Conversation
debugger should start and subsribe to RC before starting to poll
cimi
reviewed
Sep 16, 2022
Comment on lines
+102
to
104
| } else { | ||
| log.warn("No configuration poller available from SharedCommunicationObjects"); | ||
| } |
Contributor
There was a problem hiding this comment.
This warning is not useful our users - they won't know about SharedCommunicationObjects or what a configuration poller is.
This could be:
Cannot enable Dynamic Instrumentation because Remote Configuration is not enabled
Should we check remoteConfigEnabled and this log in the maybeStartDebugger method in the bootstrap class? We could then have this as a debug log here and leave it unchanged.
Comment on lines
381
to
384
| if (debuggerEnabled) { | ||
| // start debugger before remote config to subscribe to it before starting to poll | ||
| startDebuggerAgent(instrumentation, scoClass, sco); | ||
| } |
Contributor
There was a problem hiding this comment.
For consistency with the other products, should we make a maybeStartDebugger method?
Start it in only one place: maybeStartRemoteConfig in Agent class
bantonsson
approved these changes
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
debugger should start and subscribe to RC before starting to poll
Product (Debugger or AppSec) shouldn't start ConfigurationPoller, but only perform in one place once everybody has subscribed to it
Motivation
fix race condition spotted by smoke tests
Additional Notes