Update JMXFetchTest to test a real process rather than use flaky reflection hacks - #2406
Merged
Conversation
richardstartin
approved these changes
Feb 12, 2021
mcculls
force-pushed
the
mcculls/fixJmxTest
branch
from
February 12, 2021 17:14
edd1f25 to
44ac691
Compare
…aky reflection hacks
mcculls
force-pushed
the
mcculls/fixJmxTest
branch
from
February 12, 2021 17:22
44ac691 to
8f0864f
Compare
tylerbenson
approved these changes
Feb 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix a test failure I saw recently because the local
JMXFETCH_CLASSLOADERfield wasn't initialized at the time this test ran. Tests should not rely on the status of any agent attached to the build process, so I changed this to use a forked process instead.