Repository navigation
Update instrumentation Gradle dependencies - #12924
dd-octo-sts[bot] wants to merge 1 commit into
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
More details
Compatibility with the refreshed dependency versions remains unverified by execution: tests were not run, and CI status was inaccessible (HTTP 403).
🤖 Bits Code Review · Commit 6f74126
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f74126f13
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # This file is expected to be part of source control. | ||
| # To regenerate this file, run: ./gradlew :dd-java-agent:instrumentation:confluent-schema-registry:confluent-schema-registry-4.1:dependencies --write-locks | ||
| at.yawk.lz4:lz4-java:1.11.4=latestDepTestRuntimeClasspath | ||
| at.yawk.lz4:lz4-java:1.11.1=latestDepTestRuntimeClasspath |
There was a problem hiding this comment.
Keep the Confluent test on LZ4 1.11.4
When latestDepTest resolves this runtime classpath, the lock now downgrades LZ4 to 1.11.1 even though gradle/libs.versions.toml selects 1.11.4 and the immediately preceding LZ4 update intentionally moved this affected lockfile to that version. Because dependency locking pins the exact runtime dependency, this test silently stops covering the repository-selected LZ4 release; retain 1.11.4 while refreshing the other dynamic dependencies.
AGENTS.md reference: AGENTS.md:L77-L78
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
This PR updates the Gradle dependency locks for instrumentations and their tests.
Motivation
Refresh Gradle dependencies to make sure to test latest versions of dependencies within their supported versions.
Dependency age policy
48h cooldown, reverted
Too new and no older eligible version exists, so the lockfiles were reverted to the baseline.
com.fasterxml.jackson.core:jackson-core:2.22.4is 43h away from meeting cooldowncom.fasterxml.jackson.core:jackson-databind:2.22.4is 43h away from meeting cooldowncom.fasterxml.jackson:jackson-bom:2.22.4is 43h away from meeting cooldownorg.scala-lang:scala-library:2.13.19-M1is 39h away from meeting cooldown48h cooldown, updated to the previous version
Too new, so an older eligible version was used instead.
com.openai:openai-java-client-okhttp:4.85.0is 44h away from meeting cooldown, updated to4.82.0com.openai:openai-java-core:4.85.0is 44h away from meeting cooldown, updated to4.82.0com.openai:openai-java:4.85.0is 44h away from meeting cooldown, updated to4.82.0Contributor Checklist