Skip to content

Fix typo reason debugger metrics - #12913

Open
jpbempel wants to merge 1 commit into
masterfrom
jpbempel/fix-typo-metric-reason
Open

Fix typo reason debugger metrics#12913
jpbempel wants to merge 1 commit into
masterfrom
jpbempel/fix-typo-metric-reason

Conversation

@jpbempel

@jpbempel jpbempel commented Oct 16, 2026

Copy link
Copy Markdown
Member

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@jpbempel
jpbempel requested a review from a team as a code owner October 16, 2026 14:35
@jpbempel
jpbempel requested review from tylfin and removed request for a team October 16, 2026 14:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T14:37:47.842723Z 35b1625 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dd-octo-sts

dd-octo-sts Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@jpbempel jpbempel added comp: debugger Dynamic Instrumentation type: bug fix Bug fix labels Oct 16, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Oct 16, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35b1625964

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread internal-api/src/main/java/datadog/trace/api/debugger/DebuggerMetricCollector.java
@jpbempel
jpbempel force-pushed the jpbempel/fix-typo-metric-reason branch from 35b1625 to 09f5023 Compare October 16, 2026 14:37
datadog-prod-us1-4[bot]
datadog-prod-us1-4 Bot reviewed Oct 16, 2026
View reviewed changes

@datadog-prod-us1-4 datadog-prod-us1-4 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

The corrected timeout reason tag conflicts with an unchanged unit-test assertion, causing a deterministic test failure until the expected value is updated.

Open Bits AI session

🤖 Bits Code Review · Commit 35b1625

Comment thread internal-api/src/main/java/datadog/trace/api/debugger/DebuggerMetricCollector.java
@datadog-prod-us1-4

This comment has been minimized.

Sign in to view
@dd-octo-sts

dd-octo-sts Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.94 s 13.90 s [-0.5%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent 12.83 s 12.94 s [-1.7%; -0.1%] (maybe better)
startup:petclinic:appsec:Agent 17.67 s 17.48 s [+0.2%; +2.0%] (maybe worse)
startup:petclinic:iast:Agent 17.54 s 16.84 s [-0.2%; +8.5%] (no difference)
startup:petclinic:profiling:Agent 17.31 s 17.38 s [-1.4%; +0.6%] (no difference)
startup:petclinic:sca:Agent 17.67 s 17.61 s [-0.6%; +1.4%] (no difference)
startup:petclinic:tracing:Agent 16.70 s 16.76 s [-1.2%; +0.5%] (no difference)

Commit: 35b16259 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@datadog-prod-us1-4 datadog-prod-us1-4[bot] datadog-prod-us1-4[bot] left review comments
@tylfin tylfin tylfin approved these changes

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation type: bug fix Bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpbempel @tylfin