Skip to content

Make CI curl calls fail on HTTP errors and retry - #12911

Open
cbeauchesne wants to merge 2 commits into
masterfrom
cbeauchesne/curl-retry-fail
Open

Make CI curl calls fail on HTTP errors and retry#12911
cbeauchesne wants to merge 2 commits into
masterfrom
cbeauchesne/curl-retry-fail

Conversation

@cbeauchesne

@cbeauchesne cbeauchesne commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Every curl run in CI on PRs and master pushes now fails on HTTP errors (--fail) and retries transient failures. A "CI scripts" rule in AGENTS.md makes new CI code follow the same pattern.

Motivation

Without retries, network blips break jobs. Without --fail, a 4xx/5xx exits 0: the exploration-tests image ran curl -s https://get.sdkman.io | bash, so a failed download silently installed nothing.

Additional Notes

  • check_test_agent_results.sh keeps its explicit HTTP status checks (a 404 is a valid answer there) and only gains retries.
  • Not changed: the vendored mvnw, and the tag/release-only jobs.

🤖 Generated with Claude Code

@cbeauchesne @claude
Make CI curl calls fail on HTTP errors and retry
6cbff64 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cbeauchesne cbeauchesne added tag: no release notes Changes to exclude from release notes type: refactoring comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM labels Oct 16, 2026
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Oct 16, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.79% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c4784cb | Docs | Give us feedback!

@pr-commenter

pr-commenter Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1792166665 1792167006
end_time 2026-10-16T16:05:56 2026-10-16T16:11:37
git_branch master cbeauchesne/curl-retry-fail
git_commit_sha fcd5425 c4784cb
start_time 2026-10-16T16:04:26 2026-10-16T16:10:07
See matching parameters
Baseline Candidate
ci_job_id 2147476034 2147476034
ci_pipeline_id 145325263 145325263
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
git_commit_date 1792165885 1792165885

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-1.442ms; -1.158ms] or [-16.327%; -13.116%]		 better
[-1.482ms; -1.196ms] or [-16.596%; -13.397%]		 better
[-1.475ms; -1.191ms] or [-16.457%; -13.285%]		 better
[-1.487ms; -1.189ms] or [-16.402%; -13.123%]		 better
[+14.857op/s; +19.744op/s] or [+13.297%; +17.670%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-14.627µs; +33.893µs] or [-4.414%; +10.229%]		 unstable
[-3.981µs; +66.236µs] or [-1.094%; +18.207%]		 unstable
[-11.723µs; +78.148µs] or [-3.088%; +20.583%]		 unstable
[-181.657µs; +23.148µs] or [-15.040%; +1.917%]		 same
scenario:basic same same same unstable
[-410.138µs; -111.912µs] or [-34.917%; -9.528%]		 unstable
[-113.020op/s; +113.020op/s] or [-5.086%; +5.086%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (363.799 µs) : 341, 387
.   : milestone, 364,
basic (346.617 µs) : 341, 352
.   : milestone, 347,
loop (8.93 ms) : 8743, 9118
.   : milestone, 8930,
section candidate
noprobe (394.926 µs) : 354, 436
.   : milestone, 395,
basic (343.213 µs) : 340, 347
.   : milestone, 343,
loop (7.591 ms) : 7583, 7599
.   : milestone, 7591,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 363.799 µs [340.659 µs, 386.939 µs]
basic 346.617 µs [341.271 µs, 351.963 µs]
loop 8.93 ms [8.743 ms, 9.118 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 394.926 µs [353.858 µs, 435.995 µs]
basic 343.213 µs [339.907 µs, 346.519 µs]
loop 7.591 ms [7.583 ms, 7.599 ms]

@dd-octo-sts

dd-octo-sts Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.97 s 13.88 s [-0.0%; +1.3%] (no difference)
startup:insecure-bank:tracing:Agent 12.89 s 12.80 s [+0.1%; +1.4%] (maybe worse)
startup:petclinic:appsec:Agent 17.67 s 17.40 s [+0.5%; +2.5%] (maybe worse)
startup:petclinic:iast:Agent 16.74 s 17.53 s [-8.7%; -0.4%] (maybe better)
startup:petclinic:profiling:Agent 17.25 s 17.17 s [-0.6%; +1.5%] (no difference)
startup:petclinic:sca:Agent 17.67 s 17.56 s [-0.1%; +1.3%] (no difference)
startup:petclinic:tracing:Agent 16.54 s 16.71 s [-2.1%; +0.1%] (no difference)

Commit: c4784cbf · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@cbeauchesne
cbeauchesne marked this pull request as ready for review October 16, 2026 15:30
@cbeauchesne
cbeauchesne requested review from a team as code owners October 16, 2026 15:30
@cbeauchesne
cbeauchesne requested review from bric3, jpbempel and randomanderson and removed request for a team October 16, 2026 15:30
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T15:33:52.257528Z 6cbff64 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Oct 16, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6cbff64af9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .gitlab/check_test_agent_results.sh Outdated
datadog-datadog-prod-us1-2[bot]
datadog-datadog-prod-us1-2 Bot reviewed Oct 16, 2026
View reviewed changes

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

HTTP download failures now stop SDKMAN installation, while the test-agent checks preserve valid 404 handling. The completed static review found no reportable regressions.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 6cbff64

@cbeauchesne @claude
Retry refused test agent connections in CI
c4784cb 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2[bot] datadog-datadog-prod-us1-2[bot] left review comments
@bric3 bric3 bric3 approved these changes
@sarahchen6 sarahchen6 sarahchen6 approved these changes
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD approved these changes
@jpbempel jpbempel Awaiting requested review from jpbempel jpbempel is a code owner automatically assigned from DataDog/debugger-java
@randomanderson randomanderson Awaiting requested review from randomanderson randomanderson is a code owner automatically assigned from DataDog/apm-release-platform

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbeauchesne @bric3 @sarahchen6 @AlexeyKuznetsov-DD