Restore Confluent versions to Kafka Muzzle checks - #12180
Restore Confluent versions to Kafka Muzzle checks#12180AlexeyKuznetsov-DD wants to merge 1 commit into
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 8e05f86 | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
There was a problem hiding this comment.
Confluent metadata is fail-open: all five changed Muzzle planners succeeded with zero -ce/-ccs tasks when the added endpoint was unavailable, allowing CI to silently retain Central-only coverage.
📊 Validated against 8 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 8e05f86 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
| @@ -1,4 +1,6 @@ | |||
| muzzle { | |||
| extraRepository("confluent-releases", "https://packages.confluent.io/maven/") | |||
There was a problem hiding this comment.
Fail closed when Confluent metadata contributes no versions
CI can remain green with none of the Confluent compatibility coverage this PR is intended to restore.
Assertion details
- Input: Run any affected Kafka Muzzle task while Maven Central is reachable and https://packages.confluent.io/maven/ is unavailable.
- Expected:
Declaring this repository to restore Confluent coverage should fail planning when it contributes no Confluent versions. The complete fix requires Muzzle plugin support for a required repository (or an equivalent contribution assertion), plus a buildSrc regression test covering a reachable Central repository and an unavailable required extra repository. - Actual:
With the added URL returning HTTP 502, direct Aether queries for kafka-clients, connect-runtime, and kafka-streams contained only Central versions. All five changed Muzzle dry-runs nevertheless returned BUILD SUCCESSFUL and planned zero -ce/-ccs tasks.
Was this helpful? React 👍 or 👎
🤖 Datadog Autotest · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
What Does This Do
Adds the Confluent Maven repository as an explicit Muzzle version source for all Kafka instrumentations that test
org.apache.kafkaartifacts.Muzzle now combines the Maven Central version list obtained through the existing Depot proxy/fallback flow with Confluent's
-ce,-ccs, and other published Kafka versions.Motivation
Depot previously returned Confluent metadata for some
org.apache.kafkacoordinates. After Depot was corrected to behave as a Maven Central proxy, those Confluent versions were no longer discoverable by Kafka Muzzle ranges, even though exact Confluent artifacts remained downloadable.Without an explicit Confluent Muzzle repository, compatibility checks could remain green while silently dropping Confluent version coverage. Declaring the upstream directly makes that coverage intentional and independent of Depot's Maven Central metadata behavior.
Additional Notes
confluent-schema-registry-4.1Muzzle repository pattern.-ceand-ccscompatibility coverage.Validation:
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: N/A