Fix SQS queue name tags from QueueUrl - #12159
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a35fbf144
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🎯 Code Coverage (details) 🔗 Commit SHA: 7cbe728 | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
More details
Queue names are now consistently derived from valid SQS QueueUrl path segments, including FIFO, query-bearing, and trailing-slash URLs; malformed or null URLs remain non-fatal and produce no fabricated tag. Focused Gradle tests could not start because plugin resolution returned HTTP 429, leaving framework-level regression execution unverified.
📊 Validated against 6 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 7cbe728 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
What Does This Do
For AWS SDK v2 SQS spans, sets
aws.queue.namefrom the queue URL when the request/span only hasQueueUrl.This covers SQS message operations such as
SendMessage,SendMessageBatch,DeleteMessage, andDeleteMessageBatch, and also SQS receive/time-in-queue spans created by theaws-java-sqs-2.0instrumentation.Motivation
In AWS SDK v2, SQS operations that act on messages identify the queue with
QueueUrl, notQueueName. As a result,aws.queue.namewas not set, and peer service inference could not use the queue name.The queue URL contains the queue name as its final path segment, similar to how SNS topic names are derived from topic ARNs. This change extracts that queue name and sets the expected queue-name tags consistently across SQS spans.
Additional Notes
Added regression coverage for sync/async SDK v2 SQS operations, legacy SQS forked tests, receive spans, and time-in-queue spans. Tests pass locally.
Solves: #12155
Supersedes: #12157
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]