chore(crashtracking): add is_crash tag to crash report - #12156
Conversation
is_crash tag to crash report
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Configured crash-tracking tags can already contain the reserved is_crash key. The new log-tag concatenation preserves that value and appends a second is_crash:true, producing conflicting tags and making crash filtering dependent on backend duplicate-key handling.
📊 Validated against 1 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 388ebfb · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
| if (!tagsBuilder.toString().isEmpty()) { | ||
| tagsBuilder.append(","); | ||
| } | ||
| tagsBuilder.append("is_crash:true").append(','); |
There was a problem hiding this comment.
Avoid duplicate is_crash tags in log output
Crash logs may be inconsistently included or excluded by is_crash queries and facets when the intake backend receives duplicate values for the same tag key.
Assertion details
- Input: A crash configuration with tags
is_crash:false,team:paymentsreachesCrashUploader.uploadToLogs. - Expected: The emitted
ddtagscontains one authoritativeis_crash:truetag, without a conflicting configured value. - Actual: The new builder appends
is_crash:trueafter the configured tags, yielding conflictingis_crash:falseandis_crash:trueentries before the generated version/PID tags. The focused adversarial test reproduced the output mismatch.
Was this helpful? React 👍 or 👎
🤖 Datadog Autotest · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
Telemetry path did not have this tag
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
388ebfb to
823dca9
Compare
823dca9 to
7fda6a3
Compare
What Does This Do
Adds
is_crashtag to crash reportsMotivation
QOL improvement for querying + parity with other runtimes
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]