Fix OTLP trace-metrics attribute compliance gaps by mabdinur · Pull Request #12144 · DataDog/dd-trace-java

mabdinur · 2026-08-04T19:47:02Z

Summary

Aligns Java OTLP trace metrics with the cross-tracer contract tracked by system-tests#7466.

Emits service.name on every data point, canonical SPAN_KIND_* values, and string STATUS_CODE_* values.
Maps absent, empty, unknown, or unrecognized trace-metric span kinds to SPAN_KIND_INTERNAL; never emits SPAN_KIND_UNSPECIFIED.
Makes OTLP trace-metric output independent of DD_TRACE_OTEL_SEMANTICS_ENABLED; global parsing, telemetry, and the public config accessor remain unchanged.
Always emits available OTel and datadog.* attributes, including native booleans for datadog.span.top_level and known datadog.is_trace_root values.
Emits origin, peer tags, configured additional metric tags, and datadog.svc_src as a string when service source is present.
Adds Datadog runtime/process resource attributes and generated process-tag precedence.
Keeps aggregation extras as Map<String, Object>; no wrapper.

Validation:

focused writer and metrics-package tests
Spotless
forbidden APIs and SpotBugs

Brings the traces.span.sdk.metrics.duration OTLP export in line with the RFC's attribute spec: emit datadog.process_tags as one arrayValue resource attribute instead of split per-key attributes, add the missing datadog.is_trace_root data-point attribute, canonicalize span.kind to the OTel Span Metrics Connector's uppercase convention, and emit status.code unconditionally with STATUS_CODE_OK/ERROR values instead of only on error. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Corrects a reversed static-import order in OtlpResourceJson.java and reformats a few lines flagged by google-java-format. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

dd-octo-sts · 2026-08-04T20:32:12Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	14.72 s	14.72 s	[-0.7%; +0.7%] (no difference)
startup:insecure-bank:tracing:Agent	13.61 s	13.65 s	[-1.0%; +0.3%] (no difference)
startup:petclinic:appsec:Agent	16.86 s	16.81 s	[-0.8%; +1.4%] (no difference)
startup:petclinic:iast:Agent	16.87 s	16.36 s	[-1.4%; +7.6%] (no difference)
startup:petclinic:profiling:Agent	16.81 s	16.78 s	[-0.8%; +1.2%] (no difference)
startup:petclinic:sca:Agent	16.77 s	16.56 s	[+0.2%; +2.2%] (maybe worse)
startup:petclinic:tracing:Agent	15.99 s	16.16 s	[-2.1%; -0.1%] (maybe better)

Commit: ad5b0efa · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

service.name was only emitted on a data point when it differed from the writer's configured default service, which contradicts the RFC's always-present requirement already applied to status.code, span.kind, and is_trace_root. Drop the now-unused defaultService field/param.

The earlier spotless fix collapsed this Javadoc onto one physical line, but the formatter's own target (confirmed from the spotless job trace) keeps the three-line /** ... */ block and only unwraps the content itself onto a single line inside it.

Reuses the existing STRING_ARRAY_ATTRIBUTE visitor plumbing already wired for both proto and JSON collectors. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

This reverts commit e47c318.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e47c3183cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

datadog-prod-us1-3

When process-tag propagation is enabled, a user global tag named datadog.process_tags produces two OTLP resource attributes with the same key: the user string and the new process-tag array. Duplicate OTLP keys have ambiguous consumer behavior, so the generated array must take precedence.

_{📊 Validated against 10 scenarios · Open Bits AI session}

_{🤖 Datadog Autotest · Commit e47c318 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest}

Always emit available Datadog attributes alongside OTel attributes and include datadog.svc_src when the aggregation key carries a service source.

mhlidd

Overall LGTM, just some small comments

mabdinur added type: bug fix Bug fix comp: metrics Metrics tag: ai generated Largely based on code generated by an AI or LLM labels Aug 4, 2026

Fix spotless formatting violations

eb11a69

Corrects a reversed static-import order in OtlpResourceJson.java and reformats a few lines flagged by google-java-format. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

This comment has been minimized.

Sign in to view

mabdinur added 2 commits August 4, 2026 16:49

mabdinur mentioned this pull request Aug 5, 2026

test(otlp-trace-metrics): maintain parity with the OTEP spec DataDog/system-tests#7363

Merged

2 tasks

mabdinur and others added 2 commits August 5, 2026 12:16

Emit datadog.peer_tags on OTLP trace-metrics data points

43eb7e9

Reuses the existing STRING_ARRAY_ATTRIBUTE visitor plumbing already wired for both proto and JSON collectors. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Merge branch 'master' into munir/otlp-trace-metrics-fixes

325a854

This was referenced Aug 5, 2026

test(otlp-trace-metrics): align cross-tracer attributes DataDog/system-tests#7466

Open

Fix OTLP trace metrics attribute gaps in span stats serializer DataDog/dd-trace-dotnet#8992

Open

Preserve OTLP resource attribute types

e47c318

mabdinur requested a review from mhlidd August 5, 2026 19:51

mabdinur marked this pull request as ready for review August 5, 2026 19:51

mabdinur requested a review from a team as a code owner August 5, 2026 19:51

Revert "Preserve OTLP resource attribute types"

b67bf6c

This reverts commit e47c318.

chatgpt-codex-connector Bot reviewed Aug 5, 2026

View reviewed changes

Comment thread dd-trace-core/src/main/java/datadog/trace/core/otlp/metrics/OtlpStatsMetricWriter.java

Comment thread dd-trace-core/src/main/java/datadog/trace/core/otlp/common/OtlpResourceAttributes.java Outdated

Remove local OTLP resource attribute casts

4c07a19

datadog-prod-us1-3 Bot reviewed Aug 5, 2026

View reviewed changes

Comment thread dd-trace-core/src/main/java/datadog/trace/core/otlp/common/OtlpResourceAttributes.java Outdated

mabdinur added 5 commits August 5, 2026 18:50

Avoid duplicate OTLP resource attributes

207ab6d

Restrict OTLP semantic trace-metrics attributes

44db0a4

Restore OTLP trace-metrics attribute semantics

35657c0

Fix OTLP Datadog attribute filtering

ed9c080

Make OTLP trace metrics mode-independent

bd53c6e

Always emit available Datadog attributes alongside OTel attributes and include datadog.svc_src when the aggregation key carries a service source.

mhlidd reviewed Aug 6, 2026

View reviewed changes

mabdinur added 2 commits August 6, 2026 14:46

Remove obsolete OTLP semantics mode wording

6525e19

Handle missing OTLP trace metric span kind

ad5b0ef

mhlidd approved these changes Aug 6, 2026

View reviewed changes

Navigation Menu

Uh oh!

Fix OTLP trace-metrics attribute compliance gaps - #12144

Fix OTLP trace-metrics attribute compliance gaps#12144
mabdinur wants to merge 16 commits into
masterfrom
munir/otlp-trace-metrics-fixes

mabdinur commented Aug 4, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

dd-octo-sts Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

datadog-prod-us1-3 Bot left a comment

Uh oh!

Uh oh!

mhlidd left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mabdinur commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

This comment has been minimized.

dd-octo-sts Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

datadog-prod-us1-3 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mhlidd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mabdinur commented Aug 4, 2026 •

edited

Loading

dd-octo-sts Bot commented Aug 4, 2026 •

edited

Loading