Wire -Pjmh.includes and -PtestJvm into internal-api JMH config#11703
Open
dougqh wants to merge 1 commit into
Open
Wire -Pjmh.includes and -PtestJvm into internal-api JMH config#11703dougqh wants to merge 1 commit into
dougqh wants to merge 1 commit into
Conversation
Without this, -Pjmh.includes is silently ignored by the me.champeau.jmh plugin, requiring a full fat-jar build to run a single benchmark. -PtestJvm was also ignored for JMH execution, defaulting to the Gradle daemon JVM regardless of the requested version. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
Wires two previously-ignored Gradle properties into the
internal-apiJMH configuration:-Pjmh.includes=<pattern>— filters which benchmarks run. Previously silently ignored by theme.champeau.jmhplugin, requiring a full fat-jar build to run a single benchmark.-PtestJvm=<version>— selects the JVM used for benchmark execution. Previously ignored, defaulting to whatever JVM the Gradle daemon happened to use.Usage:
Motivation
Running a single benchmark without this fix required building the full fat-jar and invoking it manually. The JVM defaulted to the daemon JVM rather than the requested version, making results non-reproducible across machines.
Additional Notes
The same pattern applies to other modules that use
me.champeau.jmh(there are ~10 others). This PR fixesinternal-apiwhere current benchmark development is happening; other modules can adopt the pattern as needed.tag: no release note🤖 Generated with Claude Code