feat(spring): Spring Boot 4 / Spring Framework 7 — spring-scheduling-3.1 latestDepTest#11598
feat(spring): Spring Boot 4 / Spring Framework 7 — spring-scheduling-3.1 latestDepTest#11598wconti27 wants to merge 2 commits into
Conversation
…o JUnit5 Java and fix SpannedMethodInvocation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
PR Blocked - Invalid Label The pull request introduced unexpected labels:
This PR is blocked until:
Note: Simply removing labels from the pull request is not enough - a maintainer must delete this comment then remove the label to remove the block. |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8886d2cb4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| latestDepTestImplementation group: 'org.springframework', name: 'spring-context', version: '6.+' | ||
| latestDepTestImplementation group: 'org.springframework.boot', name: 'spring-boot-starter-data-jpa', version: '3.+' | ||
| latestDepTestImplementation group: 'org.springframework', name: 'spring-context', version: '7.+' | ||
| latestDepTestImplementation group: 'org.springframework.boot', name: 'spring-boot-starter-data-jpa', version: '4.+' |
There was a problem hiding this comment.
Bump the latestDepTest actuator dependency too
With this change latestDepTest now resolves Boot 4 for spring-boot-starter-data-jpa, but the same suite still inherits spring-boot-starter-actuator:2.4.0 from testImplementation (visible in the regenerated lockfile for latestDepTestCompileClasspath). The latest-dep scheduling tests import and instantiate ScheduledTasksEndpoint, so they are still exercising the Boot 2.4 actuator artifact mixed with Boot 4 core/autoconfigure rather than validating the Boot 4 scheduling endpoint; add a latestDepTestImplementation override for the actuator starter/artifact alongside the Boot 4 JPA starter.
Useful? React with 👍 / 👎.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Summary
Bumps
spring-scheduling-3.1latestDepTest pins from Spring Framework 6.x / Boot 3.x to Spring Framework 7.x / Boot 4.x.Also migrates all 3 Groovy/Spock test files to JUnit 5 Java (required by CLAUDE.md for any test file edit), and fixes
SpannedMethodInvocationcompatibility with the updated dependency chain.Changes
build.gradle:spring-context 6.+→7.+,spring-boot-starter-data-jpa 3.+→4.+gradle.lockfile: regenerated for Boot 4.0.0-RC2 / SF 7.0.xShedlockTest.groovy→ShedlockTest.java(Spock → JUnit 5)SpringSchedulingTest.groovy→SpringSchedulingTest.java+SpringSchedulingErrorTest.javaSpringAsyncTest.groovy→SpringAsyncTest.java+SpringAsyncErrorTest.javaSpannedMethodInvocation.java: compatibility fixVerification
./gradlew :dd-java-agent:instrumentation:spring:spring-scheduling-3.1:latestDepTest -PtestJvm=17— BUILD SUCCESSFUL with Spring Framework 7.0.x / Boot 4.0.0-RC2.Part of: #11597
🤖 Generated with Claude Code