Bump Gradle daemon JDK to 25#11570
Conversation
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Kotlin 2.0.21 fails to parse JDK 25 version strings (IllegalArgumentException in JavaVersion.parse). Kotlin 2.1.20 resolves this. JDK 25 javadoc rejects the old Oracle Java 8 docs URL which now redirects; replace with the stable canonical URL. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
JDK 25 javadoc treats HTTP redirects as hard errors; Oracle's Java 8 API URL now redirects. Running javadoc with the JDK 8 tool is semantically correct (source=8) and avoids the redirect restriction. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4d61fdbe6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## Kotlin | ||
| kotlin = "1.6.21" | ||
| kotlin-plugin = "2.0.21" | ||
| kotlin-plugin = "2.1.20" |
There was a problem hiding this comment.
Refresh Kotlin lockfiles with the plugin bump
When this bumps the Kotlin Gradle plugin to 2.1.20 for Java 25 support, the existing Kotlin module lockfiles are left pinning the Kotlin build-tool configurations to 2.0.21 (checked dd-java-agent/agent-ci-visibility, dd-smoke-tests/iast-propagation, dd-java-agent/instrumentation/spring/spring-messaging-4.0, dd-java-agent/instrumentation/kotlin-coroutines-1.3, and dd-java-agent/instrumentation/junit/junit-4/junit-4.10). Because this repo's dependency locking applies whenever configurations such as kotlinCompilerClasspath are resolved, those modules can still resolve the old Java-25-incompatible compiler/daemon artifacts despite the catalog saying 2.1.20; please regenerate and commit the affected gradle.lockfile files with --write-locks.
Useful? React with 👍 / 👎.
What Does This Do
Bumps the Gradle daemon JDK from 21 to 25 via
./gradlew updateDaemonJvm --jvm-version=25.Motivation
Keep the build daemon on the latest JDK release.
Additional Notes
2.0.21to2.1.20, Kotlin 2.1.x is the first to support running on Java 25javadoctreats HTTP redirects as hard errors, and it happens that the Oracle Java 8 API link appears to be broken; running with JDK 8's own tool avoids this.