Skip to content

Migrate utils module Groovy tests to Java tests#11569

Open
sarahchen6 wants to merge 10 commits into
masterfrom
sarahchen6/migrate-utils-tests
Open

Migrate utils module Groovy tests to Java tests#11569
sarahchen6 wants to merge 10 commits into
masterfrom
sarahchen6/migrate-utils-tests

Conversation

@sarahchen6
Copy link
Copy Markdown
Contributor

@sarahchen6 sarahchen6 commented Jun 4, 2026 •
edited
Loading

What Does This Do

Migrate Groovy tests in the utils module to Java without changing any functionality

Introduce TableTest converter for boxed values

Motivation

This is part of a broader initiative to migrate all testing in this repo to JUnit

Additional Notes

Confirmation that we did not lose tests (note that a few tests were combined in this PR):

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@sarahchen6 sarahchen6 added comp: testing Testing tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels Jun 4, 2026
sarahchen6
sarahchen6 commented Jun 4, 2026
View reviewed changes
Comment thread utils/config-utils/src/test/java/datadog/trace/api/ConfigSettingTest.java Outdated
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Jun 4, 2026 •
edited
Loading

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.04 s 13.96 s [-0.5%; +1.7%] (no difference)
startup:insecure-bank:tracing:Agent 12.93 s 13.14 s [-2.8%; -0.4%] (maybe better)
startup:petclinic:appsec:Agent 16.55 s 16.34 s [-0.2%; +2.8%] (no difference)
startup:petclinic:iast:Agent 16.49 s 15.70 s [-3.9%; +14.0%] (unstable)
startup:petclinic:profiling:Agent 16.48 s 16.63 s [-1.8%; -0.0%] (maybe better)
startup:petclinic:tracing:Agent 15.79 s 15.85 s [-1.6%; +0.9%] (no difference)

Commit: f3b0ddae · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

sarahchen6
sarahchen6 commented Jun 4, 2026
View reviewed changes
Comment thread ...nfig-utils/src/test/java/datadog/trace/bootstrap/config/provider/StableConfigSourceTest.java
StableConfigSource stableConfigSource =
new StableConfigSource(filePath.toString(), ConfigOrigin.LOCAL_STABLE_CONFIG);

// Create ConfigProvider via reflection (constructor is private)
Copy link
Copy Markdown
Contributor Author

@sarahchen6 sarahchen6 Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the alternative was having this test file a stableconfig subfolder so that package-private safeToString() can be accessed 🤔

sarahchen6
sarahchen6 commented Jun 4, 2026
View reviewed changes
Comment thread utils/container-utils/src/test/java/datadog/common/container/ContainerInfoTest.java
// spotless:on

@ParameterizedTest
@MethodSource("containerInfoParsedFromFileContentArguments")
Copy link
Copy Markdown
Contributor Author

@sarahchen6 sarahchen6 Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This MethodSource was kept for readability -- TableTest requires inputs to be on one line

@datadog-datadog-prod-us1-2

This comment has been minimized.

Sign in to view
@sarahchen6 sarahchen6 marked this pull request as ready for review June 4, 2026 20:55
@sarahchen6 sarahchen6 requested review from a team as code owners June 4, 2026 20:55
@sarahchen6 sarahchen6 requested a review from mhlidd June 4, 2026 20:55
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 54ccc2aa75

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ...nfig-utils/src/test/java/datadog/trace/bootstrap/config/provider/StableConfigSourceTest.java
AlexeyKuznetsov-DD
AlexeyKuznetsov-DD reviewed Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left minor comments about code style

Comment thread utils/config-utils/src/test/java/datadog/trace/api/env/CapturedEnvironmentTest.java Outdated
Comment thread utils/config-utils/src/test/java/datadog/trace/api/env/CapturedEnvironmentTest.java Outdated
Comment thread utils/config-utils/src/test/java/datadog/trace/api/ConfigSettingTest.java Outdated
Comment thread utils/config-utils/src/test/java/datadog/trace/api/ConfigSettingTest.java Outdated
Comment thread utils/config-utils/src/test/java/datadog/trace/api/ConfigSettingTest.java Outdated
Comment thread .../config-utils/src/test/java/datadog/trace/bootstrap/config/provider/ConfigConverterTest.java Outdated
Comment thread .../config-utils/src/test/java/datadog/trace/bootstrap/config/provider/ConfigConverterTest.java Outdated
Comment thread .../config-utils/src/test/java/datadog/trace/bootstrap/config/provider/ConfigConverterTest.java Outdated
Comment thread utils/junit-utils/src/main/java/datadog/trace/junit/utils/tabletest/BoxedValueConverter.java
Comment thread utils/time-utils/src/test/java/datadog/trace/api/time/TimeUtilsTest.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD left review comments

@mhlidd mhlidd Awaiting requested review from mhlidd mhlidd is a code owner automatically assigned from DataDog/apm-java

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

comp: testing Testing tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarahchen6 @AlexeyKuznetsov-DD