Skip to content

Update dd-instrument-java dependency to v0.0.4#11567

Open
mcculls wants to merge 2 commits into
masterfrom
mcculls/dd-instrument-java-0.0.4
Open

Update dd-instrument-java dependency to v0.0.4#11567
mcculls wants to merge 2 commits into
masterfrom
mcculls/dd-instrument-java-0.0.4

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Jun 4, 2026 •
edited
Loading

Motivation

Performance

  • Reduce allocations when building ClassNameTries
  • Use ISO_8859_1 for ASCII fast path in ClassFile.utf()
  • Optimize ClassInfoCache lookups when the cache is stable
  • Reduce size of ClassInfoCache by 32 bytes per cache entry

Fixes

  • Fix edge case involving round-tripping an empty ClassNameTrie
  • ClassInjector: fall back to Class.forName in case boot class is already defined

Dependencies

  • Update bundled ASM to 9.10 for Java 27 support

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@mcculls mcculls added type: enhancement Enhancements and improvements comp: core Tracer core tag: dependencies Dependencies related changes labels Jun 4, 2026
@datadog-prod-us1-4

This comment has been minimized.

Sign in to view
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jun 4, 2026 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1780606253 1780606600
end_time 2026-06-04T20:52:19 2026-06-04T20:58:06
git_branch master mcculls/dd-instrument-java-0.0.4
git_commit_sha bacdc33 0ebb0b9
start_time 2026-06-04T20:50:54 2026-06-04T20:56:41
See matching parameters
Baseline Candidate
ci_job_id 1744688484 1744688484
ci_pipeline_id 117183090 117183090
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1780605650 1780605650

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-33.859µs; +18.371µs] or [-11.315%; +6.139%]		 unstable
[-46.925µs; +26.629µs] or [-13.658%; +7.751%]		 unstable
[-62.089µs; +35.097µs] or [-17.176%; +9.709%]		 unstable
[+76.748µs; +307.034µs] or [+6.536%; +26.146%]		 same
scenario:basic same same same unstable
[+175.139µs; +459.934µs] or [+17.746%; +46.604%]		 unstable
[-99.866op/s; +221.817op/s] or [-4.095%; +9.095%]
scenario:loop unsure
[-6.550µs; -1.239µs] or [-0.074%; -0.014%]		 same same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (343.574 µs) : 301, 386
.   : milestone, 344,
basic (299.577 µs) : 292, 307
.   : milestone, 300,
loop (8.985 ms) : 8979, 8991
.   : milestone, 8985,
section candidate
noprobe (333.426 µs) : 308, 359
.   : milestone, 333,
basic (295.277 µs) : 290, 301
.   : milestone, 295,
loop (8.982 ms) : 8977, 8988
.   : milestone, 8982,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 343.574 µs [301.039 µs, 386.109 µs]
basic 299.577 µs [292.427 µs, 306.728 µs]
loop 8.985 ms [8.979 ms, 8.991 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 333.426 µs [308.22 µs, 358.632 µs]
basic 295.277 µs [289.628 µs, 300.925 µs]
loop 8.982 ms [8.977 ms, 8.988 ms]

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Jun 4, 2026 •
edited
Loading

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.88 s 13.96 s [-1.5%; +0.4%] (no difference)
startup:insecure-bank:tracing:Agent 12.83 s 12.98 s [-2.2%; +0.0%] (no difference)
startup:petclinic:appsec:Agent 16.46 s 16.43 s [-1.3%; +1.7%] (no difference)
startup:petclinic:iast:Agent 15.47 s 16.61 s [-15.3%; +1.6%] (unstable)
startup:petclinic:profiling:Agent 16.39 s 16.50 s [-1.6%; +0.1%] (no difference)
startup:petclinic:tracing:Agent 15.73 s 16.00 s [-3.0%; -0.4%] (maybe better)

Commit: 0ebb0b92 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@mcculls mcculls changed the title Update dd-instrument-java to v0.0.4 Update dd-instrument-java dependency to v0.0.4 Jun 4, 2026
@mcculls mcculls marked this pull request as ready for review June 4, 2026 18:08
@mcculls mcculls requested review from a team as code owners June 4, 2026 18:08
@mcculls mcculls requested review from andreimatei and ygree and removed request for a team June 4, 2026 18:08
@mcculls mcculls enabled auto-merge June 4, 2026 18:13
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de1fadfcd6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread gradle/libs.versions.toml
ygree
ygree approved these changes Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Does this PR also need to update the lock file, or can it wait for the regular update?

@mcculls mcculls added this pull request to the merge queue Jun 4, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Jun 4, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Jun 4, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-06-04 18:54:14 UTC ℹ️ Start processing command /merge

2026-06-04 18:54:18 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-06-04 20:01:17 UTC 🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr.
It's probably because:

  • some mandatory checkruns are failing:
    • Check pull request labels
    • Check pull requests
    • Enforce Groovy migration
  • PR is conflicting with its base branch
Details

Error: PUT https://api.github.com/repos/DataDog/dd-trace-java/pulls/11567/merge: 405 Pull Request has merge conflicts [] (Request ID: AB0D:D2570:1A75A5C:632C224:6A21D980)

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 50, startedEventID: 51, identity: 1@github-worker-9c4f75b79-75pck@): PUT https://api.github.com/repos/DataDog/dd-trace-java/pulls/11567/merge: 405 Pull Request has merge conflicts [] (Request ID: AB0D:D2570:1A75A5C:632C224:6A21D980) (type: GitFailure, retryable: false): PUT https://api.github.com/repos/DataDog/dd-trace-java/pulls/11567/merge: 405 Pull Request has merge conflicts [] (type: ErrorResponse, retryable: true)

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 4, 2026
@mcculls
Copy link
Copy Markdown
Contributor Author

mcculls commented Jun 4, 2026

Looks good! Does this PR also need to update the lock file, or can it wait for the regular update?

@ygree I checked with @PerfectSlayer and we shouldn't update the lock files for PRs that update these kind of dependencies (the build will still use the right version) - instead we should leave the lock files to the scheduled task

bric3
bric3 approved these changes Jun 4, 2026
View reviewed changes
Comment thread gradle/libs.versions.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@bric3 bric3 bric3 approved these changes

@ygree ygree ygree approved these changes

@andreimatei andreimatei Awaiting requested review from andreimatei andreimatei is a code owner automatically assigned from DataDog/debugger-java

Assignees

No one assigned

Labels

comp: core Tracer core tag: dependencies Dependencies related changes type: enhancement Enhancements and improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @bric3 @ygree