feat(profiling): [PROF-14883] Publish thread context attribute keys at process start#11558
Open
ivoanjo wants to merge 1 commit into
Open
feat(profiling): [PROF-14883] Publish thread context attribute keys at process start#11558ivoanjo wants to merge 1 commit into
ivoanjo wants to merge 1 commit into
Conversation
**What does this PR do?** This PR adjusts the `ProcessContext` setup to match the change in DataDog/java-profiler#576 to publish the context attributes at process start. **Motivation:** Publishing the context attributes at process start enables outside readers of thread context to immediately start reading this information; prior to this change they were impacted by the profiler start delay. **Additional Notes:** This PR relies on the API changes introduced in DataDog/java-profiler#576 and will need to be merged together with an upgrade to the latest java-profiler. **How to test the change?** This change includes test coverage.
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
3 tasks
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR adjusts the
ProcessContextsetup to match the change in DataDog/java-profiler#576 to publish the context attributes at process start.Motivation
Publishing the context attributes at process start enables outside readers of thread context to immediately start reading this information; prior to this change they were impacted by the profiler start delay.
Additional Notes
This PR relies on the API changes introduced in
DataDog/java-profiler#576 and will need to be merged together with an upgrade to the latest java-profiler.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROF-14883]