Skip to content

Fix Gradle custom test task wiring#11538

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
alexeyk/gradle-forked-tests-fixed
Jun 3, 2026
Merged

Fix Gradle custom test task wiring#11538
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
alexeyk/gradle-forked-tests-fixed

Conversation

@AlexeyKuznetsov-DD
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Jun 2, 2026 •
edited
Loading

What Does This Do

Wires custom Test tasks explicitly to their intended source set outputs:

  • shared forkedTest -> sourceSets.test
  • shared testRuntimeActivation -> sourceSets.test
  • Scala cross-version tasks -> regular test classes plus version-specific Scala support classes

Motivation

After moving to Gradle 9.5.1, these custom Test tasks no longer inherited the implicit test source set wiring that made them run under Gradle 8.14.4; without explicit testClassesDirs/classpath, they were skipped as NO-SOURCE.

Additional Notes

Checked custom Test task wiring across the repo. The only remaining empty task is the parent :dd-java-agent:instrumentation:latestDepTest placeholder.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added type: bug Bug report and fix tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM labels Jun 2, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested a review from bric3 June 2, 2026 23:03
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD force-pushed the alexeyk/gradle-forked-tests-fixed branch from 8595a66 to f0cdabd Compare June 2, 2026 23:07
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD force-pushed the alexeyk/gradle-forked-tests-fixed branch from f0cdabd to 7868b3a Compare June 2, 2026 23:08
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD changed the title Fix forkedTest source set wiring Fix Gradle custom test task wiring Jun 2, 2026
@datadog-prod-us1-3

This comment has been minimized.

Sign in to view
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Jun 2, 2026

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.84 s 14.68 s [-0.5%; +2.7%] (no difference)
startup:insecure-bank:tracing:Agent 13.69 s 13.74 s [-1.8%; +1.1%] (no difference)
startup:petclinic:appsec:Agent 16.66 s 16.39 s [+0.0%; +3.2%] (maybe worse)
startup:petclinic:iast:Agent 16.54 s 16.57 s [-1.5%; +1.1%] (no difference)
startup:petclinic:profiling:Agent 16.40 s 16.50 s [-2.0%; +0.8%] (no difference)
startup:petclinic:tracing:Agent 14.96 s 16.14 s [-15.3%; +0.8%] (unstable)

Commit: 87c8630a · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD marked this pull request as ready for review June 3, 2026 01:15
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from a team as code owners June 3, 2026 01:15
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from ygree and removed request for a team June 3, 2026 01:15
@AlexeyKuznetsov-DD
Copy link
Copy Markdown
Contributor Author

AlexeyKuznetsov-DD commented Jun 3, 2026

@bric3 Feel free to refactor this PR if needed.

bric3
bric3 approved these changes Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bric3 bric3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue appear to be related to a convention that has been removed in Gradle 9.x

https://docs.gradle.org/current/userguide/upgrading_major_version_9.html#test_tasks_may_no_longer_execute_expected_tests

@bric3
Copy link
Copy Markdown
Contributor

bric3 commented Jun 3, 2026

/merge -f --reason="Fixes NO SOURCES, merge queue not needed"

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Jun 3, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-06-03 08:42:56 UTC ℹ️ Start processing command /merge -f --reason="Fixes NO SOURCES, merge queue not needed"

2026-06-03 08:43:00 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 0s (p90).

2026-06-03 08:43:10 UTC ℹ️ MergeQueue: This merge request was merged

Warning

This change was merged without running any pre merge CI checks

Reason: Fixes NO SOURCES, merge queue not needed

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 8e9e1a0 into master Jun 3, 2026
759 of 762 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the alexeyk/gradle-forked-tests-fixed branch June 3, 2026 08:43
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 3, 2026
This was referenced Jun 3, 2026
Closed
Merged
@bric3 bric3 mentioned this pull request Jun 4, 2026
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3 bric3 bric3 approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-idm-java

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexeyKuznetsov-DD @bric3