Skip to content

Migrate version.gradle script plugin to Kotlin convention plugin#11345

Open
bric3 wants to merge 5 commits into
masterfrom
bdu/gradle9-write-version-convention-plugin
Open

Migrate version.gradle script plugin to Kotlin convention plugin#11345
bric3 wants to merge 5 commits into
masterfrom
bdu/gradle9-write-version-convention-plugin

Conversation

@bric3
Copy link
Copy Markdown
Contributor

@bric3 bric3 commented May 11, 2026

What does it do

Replaces the Groovy version.gradle script plugin with a convention plugin dd-trace-java.version-file.

There's 20 consumers they are now declarign it in plugins {} block (or apply plugin: where plugins {} is not available).

Adds tests for this plug-in.

Motivation

  1. Project.exec {} is removed in Gradle 9. It is also incompatible with the configuration cache.
  2. version.gradle is a Groovy script plugin, migrating to convention plugin is the way to go.

Additional Notes

Sub-PR of #10402, #11272.

@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels May 11, 2026
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more step in removing Groovy! Nice!

@bric3 bric3 mentioned this pull request May 11, 2026
9 tasks
@bric3 bric3 force-pushed the bdu/gradle9-write-version-convention-plugin branch from 6af14f7 to 930a06e Compare May 11, 2026 16:26
* `Project.exec {}` is removed in Gradle 9. It is also incompatible with
  the configuration cache.
* `gradle/version.gradle` is a Groovy script plugin, migrating to
  a convention plugin is the way to go.
@bric3 bric3 force-pushed the bdu/gradle9-write-version-convention-plugin branch from 930a06e to 72991c0 Compare May 11, 2026 16:57
@bric3 bric3 marked this pull request as ready for review May 11, 2026 16:58
@bric3 bric3 requested review from a team as code owners May 11, 2026 16:58
@bric3 bric3 requested review from claponcet, dd-oleksii, evanchooly, jandro996, leoromanovsky and mcculls and removed request for a team May 11, 2026 16:58
@bric3 bric3 changed the title Migrate version.gradle script plugin to Kotlin convention plugin Migrate version.gradle script plugin to Kotlin convention plugin May 11, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 11, 2026

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1778590352 1778590701
end_time 2026-05-12T12:54:02 2026-05-12T12:59:52
git_branch master bdu/gradle9-write-version-convention-plugin
git_commit_sha 710ca87 6ee8709
start_time 2026-05-12T12:52:33 2026-05-12T12:58:22
See matching parameters
Baseline Candidate
ci_job_id 1675698256 1675698256
ci_pipeline_id 112691016 112691016
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
git_commit_date 1778589816 1778589816

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-26.531µs; +22.297µs] or [-8.493%; +7.138%]
unstable
[-40.070µs; +34.891µs] or [-11.182%; +9.737%]
unstable
[-52.266µs; +43.611µs] or [-13.886%; +11.587%]
unstable
[-216.874µs; +118.264µs] or [-16.583%; +9.043%]
same
scenario:basic same same same unstable
[-46.076µs; +77.824µs] or [-4.276%; +7.223%]
unstable
[-151.601op/s; +151.601op/s] or [-6.367%; +6.367%]
scenario:loop unsure
[-8.767µs; -1.388µs] or [-0.098%; -0.016%]
same same same same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (358.348 µs) : 316, 400
.   : milestone, 358,
basic (312.499 µs) : 304, 321
.   : milestone, 312,
loop (9.011 ms) : 9003, 9018
.   : milestone, 9011,
section candidate
noprobe (355.759 µs) : 328, 384
.   : milestone, 356,
basic (310.265 µs) : 302, 318
.   : milestone, 310,
loop (9.015 ms) : 9007, 9022
.   : milestone, 9015,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 358.348 µs [316.48 µs, 400.217 µs]
basic 312.499 µs [303.594 µs, 321.404 µs]
loop 9.011 ms [9.003 ms, 9.018 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 355.759 µs [327.824 µs, 383.693 µs]
basic 310.265 µs [302.462 µs, 318.067 µs]
loop 9.015 ms [9.007 ms, 9.022 ms]

Copy link
Copy Markdown
Contributor

@sarahchen6 sarahchen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants