Upgrade protobuf Gradle plugin to 0.10.0 across all modules#11310
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intoMay 11, 2026
Conversation
Aligns all 8 usages from 0.8.18/0.9.3/0.9.4 to 0.10.0 as part of
Gradle 9 preparation. Also fixes related Gradle 9 incompatibilities:
* Replace deprecated `$buildDir` with `layout.buildDirectory.dir()`
and fix the generated source path (source -> sources)
* Replace eager spread-operator `*.plugins {}` with lazy `configureEach`
* Remove redundant legacy `buildscript { classpath }` block in
armeria-grpc/application
Comment on lines
37
to
43
| sourceSets { | ||
| test { | ||
| java { | ||
| srcDir "$buildDir/generated/source/proto/test/java" | ||
| srcDir layout.buildDirectory.dir("generated/sources/proto/test/java") | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Build failed and Clude suggested to delete this block completely:
The protobuf 0.8.18 plugin (pre-upgrade) didn't auto-add the directory, so the manual addition was needed.
Plugin 0.10.0 does it for you — keeping the manual line on top of it actively breaks the wiring.
AlexeyKuznetsov-DD
approved these changes
May 7, 2026
Contributor
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM, but couple of jobs failed on CI, should be easy to fix.
…e chain The `srcDirs +=` assignment discards the lazy task-dependency wiring that protobuf plugin 0.10.0 establishes between `generateTestProto` and `compileTestJava`, causing `compileTestGroovy` to miss Test2, Test3 on **clean builds**. Now that the plugin auto-registers generated sources; the block can go away.
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
10e03bd
into
master
755 of 757 checks passed
This was referenced May 11, 2026
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
that referenced
this pull request
May 11, 2026
…ion (#11343) build(gradle): remove redundant sourceSets block in protobuf-3.0 Plugin 0.10.0 automatically registers generated proto sources into the corresponding source sets. The manual srcDir addition was required for plugin 0.8.18 but is now redundant — keeping it on top of the plugin's own wiring actively breaks source set registration (review comment on #11310). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> type: EOF Co-authored-by: brice.dutheil <brice.dutheil@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Aligns all 8 usages from 0.8.18/0.9.3/0.9.4 to 0.10.0 as part of Gradle 9 preparation. Also fixes related Gradle 9 incompatibilities:
$buildDirwithlayout.buildDirectory.dir()and fix the generated source path (source -> sources)*.plugins {}with lazyconfigureEachbuildscript { classpath }block in armeria-grpc/applicationMotivation
Prepare Gradle 9
Improve build quality
Additional Notes
Sub-PR from #10402, #11272