Fix TestNG session status reported with EFD#11087
Open
daniel-mohedano wants to merge 4 commits intomasterfrom
Open
Fix TestNG session status reported with EFD#11087daniel-mohedano wants to merge 4 commits intomasterfrom
daniel-mohedano wants to merge 4 commits intomasterfrom
Conversation
Test Environment - sbt-scalatestJob Status: success
|
Test Environment - nebula-release-pluginJob Status: success
|
Test Environment - netflix-zuulJob Status: success
|
Test Environment - reactive-streams-jvmJob Status: success
|
Test Environment - pass4sJob Status: success
|
Test Environment - sonar-kotlinJob Status: success
|
Test Environment - jolokiaJob Status: success
|
Test Environment - okhttpJob Status: success
|
Test Environment - spring_bootJob Status: success
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~bc787c05dc, baseline=1.62.0-SNAPSHOT~16f8277b2e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054592
Total [baseline] (8.848 s) : 0, 8848133
Agent [candidate] (1.057 s) : 0, 1056684
Total [candidate] (8.842 s) : 0, 8841607
section iast
Agent [baseline] (1.223 s) : 0, 1222872
Total [baseline] (9.635 s) : 0, 9635190
Agent [candidate] (1.224 s) : 0, 1224220
Total [candidate] (9.575 s) : 0, 9575242
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~bc787c05dc, baseline=1.62.0-SNAPSHOT~16f8277b2e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.233 ms) : 0, 1233
crashtracking [candidate] (1.225 ms) : 0, 1225
BytebuddyAgent [baseline] (632.43 ms) : 0, 632430
BytebuddyAgent [candidate] (633.847 ms) : 0, 633847
AgentMeter [baseline] (29.365 ms) : 0, 29365
AgentMeter [candidate] (29.28 ms) : 0, 29280
GlobalTracer [baseline] (248.497 ms) : 0, 248497
GlobalTracer [candidate] (248.317 ms) : 0, 248317
AppSec [baseline] (32.01 ms) : 0, 32010
AppSec [candidate] (31.958 ms) : 0, 31958
Debugger [baseline] (59.389 ms) : 0, 59389
Debugger [candidate] (59.06 ms) : 0, 59060
Remote Config [baseline] (602.472 µs) : 0, 602
Remote Config [candidate] (584.167 µs) : 0, 584
Telemetry [baseline] (8.071 ms) : 0, 8071
Telemetry [candidate] (8.001 ms) : 0, 8001
Flare Poller [baseline] (6.767 ms) : 0, 6767
Flare Poller [candidate] (8.176 ms) : 0, 8176
section iast
crashtracking [baseline] (1.246 ms) : 0, 1246
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (800.974 ms) : 0, 800974
BytebuddyAgent [candidate] (801.402 ms) : 0, 801402
AgentMeter [baseline] (11.358 ms) : 0, 11358
AgentMeter [candidate] (11.393 ms) : 0, 11393
GlobalTracer [baseline] (239.021 ms) : 0, 239021
GlobalTracer [candidate] (239.218 ms) : 0, 239218
AppSec [baseline] (32.581 ms) : 0, 32581
AppSec [candidate] (30.263 ms) : 0, 30263
Debugger [baseline] (59.239 ms) : 0, 59239
Debugger [candidate] (59.933 ms) : 0, 59933
Remote Config [baseline] (540.39 µs) : 0, 540
Remote Config [candidate] (531.463 µs) : 0, 531
Telemetry [baseline] (12.373 ms) : 0, 12373
Telemetry [candidate] (14.271 ms) : 0, 14271
Flare Poller [baseline] (3.466 ms) : 0, 3466
Flare Poller [candidate] (3.606 ms) : 0, 3606
IAST [baseline] (25.848 ms) : 0, 25848
IAST [candidate] (25.903 ms) : 0, 25903
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~bc787c05dc, baseline=1.62.0-SNAPSHOT~16f8277b2e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058809
Total [baseline] (11.093 s) : 0, 11093174
Agent [candidate] (1.056 s) : 0, 1056323
Total [candidate] (11.081 s) : 0, 11081483
section appsec
Agent [baseline] (1.248 s) : 0, 1247814
Total [baseline] (11.153 s) : 0, 11153392
Agent [candidate] (1.247 s) : 0, 1246683
Total [candidate] (11.154 s) : 0, 11154256
section iast
Agent [baseline] (1.223 s) : 0, 1222775
Total [baseline] (11.336 s) : 0, 11336171
Agent [candidate] (1.225 s) : 0, 1225121
Total [candidate] (11.194 s) : 0, 11193659
section profiling
Agent [baseline] (1.184 s) : 0, 1183807
Total [baseline] (11.079 s) : 0, 11078658
Agent [candidate] (1.192 s) : 0, 1191724
Total [candidate] (11.301 s) : 0, 11300809
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~bc787c05dc, baseline=1.62.0-SNAPSHOT~16f8277b2e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.241 ms) : 0, 1241
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (633.345 ms) : 0, 633345
BytebuddyAgent [candidate] (632.732 ms) : 0, 632732
AgentMeter [baseline] (29.474 ms) : 0, 29474
AgentMeter [candidate] (29.327 ms) : 0, 29327
GlobalTracer [baseline] (249.071 ms) : 0, 249071
GlobalTracer [candidate] (248.492 ms) : 0, 248492
AppSec [baseline] (32.155 ms) : 0, 32155
AppSec [candidate] (32.007 ms) : 0, 32007
Debugger [baseline] (60.417 ms) : 0, 60417
Debugger [candidate] (60.104 ms) : 0, 60104
Remote Config [baseline] (607.256 µs) : 0, 607
Remote Config [candidate] (595.815 µs) : 0, 596
Telemetry [baseline] (8.131 ms) : 0, 8131
Telemetry [candidate] (8.147 ms) : 0, 8147
Flare Poller [baseline] (8.202 ms) : 0, 8202
Flare Poller [candidate] (7.606 ms) : 0, 7606
section appsec
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (661.687 ms) : 0, 661687
BytebuddyAgent [candidate] (660.875 ms) : 0, 660875
AgentMeter [baseline] (12.044 ms) : 0, 12044
AgentMeter [candidate] (12.061 ms) : 0, 12061
GlobalTracer [baseline] (249.168 ms) : 0, 249168
GlobalTracer [candidate] (248.737 ms) : 0, 248737
AppSec [baseline] (184.401 ms) : 0, 184401
AppSec [candidate] (184.295 ms) : 0, 184295
Debugger [baseline] (65.732 ms) : 0, 65732
Debugger [candidate] (65.855 ms) : 0, 65855
Remote Config [baseline] (609.279 µs) : 0, 609
Remote Config [candidate] (592.289 µs) : 0, 592
Telemetry [baseline] (8.591 ms) : 0, 8591
Telemetry [candidate] (8.631 ms) : 0, 8631
Flare Poller [baseline] (3.535 ms) : 0, 3535
Flare Poller [candidate] (3.556 ms) : 0, 3556
IAST [baseline] (24.479 ms) : 0, 24479
IAST [candidate] (24.538 ms) : 0, 24538
section iast
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (799.99 ms) : 0, 799990
BytebuddyAgent [candidate] (801.12 ms) : 0, 801120
AgentMeter [baseline] (11.372 ms) : 0, 11372
AgentMeter [candidate] (11.383 ms) : 0, 11383
GlobalTracer [baseline] (238.794 ms) : 0, 238794
GlobalTracer [candidate] (239.402 ms) : 0, 239402
AppSec [baseline] (31.104 ms) : 0, 31104
AppSec [candidate] (31.914 ms) : 0, 31914
Debugger [baseline] (60.168 ms) : 0, 60168
Debugger [candidate] (61.007 ms) : 0, 61007
Remote Config [baseline] (1.133 ms) : 0, 1133
Remote Config [candidate] (543.048 µs) : 0, 543
Telemetry [baseline] (13.378 ms) : 0, 13378
Telemetry [candidate] (12.594 ms) : 0, 12594
Flare Poller [baseline] (3.435 ms) : 0, 3435
Flare Poller [candidate] (3.479 ms) : 0, 3479
IAST [baseline] (25.865 ms) : 0, 25865
IAST [candidate] (25.852 ms) : 0, 25852
section profiling
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (691.154 ms) : 0, 691154
BytebuddyAgent [candidate] (695.861 ms) : 0, 695861
AgentMeter [baseline] (9.114 ms) : 0, 9114
AgentMeter [candidate] (9.196 ms) : 0, 9196
GlobalTracer [baseline] (207.088 ms) : 0, 207088
GlobalTracer [candidate] (208.47 ms) : 0, 208470
AppSec [baseline] (32.553 ms) : 0, 32553
AppSec [candidate] (32.785 ms) : 0, 32785
Debugger [baseline] (64.884 ms) : 0, 64884
Debugger [candidate] (66.224 ms) : 0, 66224
Remote Config [baseline] (586.063 µs) : 0, 586
Remote Config [candidate] (573.368 µs) : 0, 573
Telemetry [baseline] (8.624 ms) : 0, 8624
Telemetry [candidate] (7.903 ms) : 0, 7903
Flare Poller [baseline] (3.537 ms) : 0, 3537
Flare Poller [candidate] (3.624 ms) : 0, 3624
ProfilingAgent [baseline] (93.849 ms) : 0, 93849
ProfilingAgent [candidate] (94.568 ms) : 0, 94568
Profiling [baseline] (94.412 ms) : 0, 94412
Profiling [candidate] (95.134 ms) : 0, 95134
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~bc787c05dc, baseline=1.62.0-SNAPSHOT~16f8277b2e
dateFormat X
axisFormat %s
section baseline
no_agent (19.472 ms) : 19275, 19670
. : milestone, 19472,
appsec (18.707 ms) : 18520, 18894
. : milestone, 18707,
code_origins (18.08 ms) : 17903, 18257
. : milestone, 18080,
iast (18.018 ms) : 17838, 18199
. : milestone, 18018,
profiling (18.075 ms) : 17894, 18255
. : milestone, 18075,
tracing (17.739 ms) : 17564, 17914
. : milestone, 17739,
section candidate
no_agent (17.119 ms) : 16950, 17287
. : milestone, 17119,
appsec (19.031 ms) : 18837, 19226
. : milestone, 19031,
code_origins (17.917 ms) : 17739, 18095
. : milestone, 17917,
iast (17.851 ms) : 17673, 18028
. : milestone, 17851,
profiling (19.356 ms) : 19161, 19552
. : milestone, 19356,
tracing (17.683 ms) : 17511, 17855
. : milestone, 17683,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~bc787c05dc, baseline=1.62.0-SNAPSHOT~16f8277b2e
dateFormat X
axisFormat %s
section baseline
no_agent (1.272 ms) : 1260, 1284
. : milestone, 1272,
iast (3.387 ms) : 3342, 3432
. : milestone, 3387,
iast_FULL (6.075 ms) : 6012, 6137
. : milestone, 6075,
iast_GLOBAL (3.708 ms) : 3656, 3760
. : milestone, 3708,
profiling (2.167 ms) : 2147, 2187
. : milestone, 2167,
tracing (1.862 ms) : 1847, 1877
. : milestone, 1862,
section candidate
no_agent (1.256 ms) : 1244, 1269
. : milestone, 1256,
iast (3.595 ms) : 3543, 3647
. : milestone, 3595,
iast_FULL (6.01 ms) : 5950, 6071
. : milestone, 6010,
iast_GLOBAL (3.782 ms) : 3720, 3845
. : milestone, 3782,
profiling (2.227 ms) : 2206, 2247
. : milestone, 2227,
tracing (1.931 ms) : 1912, 1950
. : milestone, 1931,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~bc787c05dc, baseline=1.62.0-SNAPSHOT~16f8277b2e
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (3.818 ms) : 3594, 4042
. : milestone, 3818,
iast (2.276 ms) : 2206, 2345
. : milestone, 2276,
iast_GLOBAL (2.319 ms) : 2250, 2389
. : milestone, 2319,
profiling (2.106 ms) : 2051, 2161
. : milestone, 2106,
tracing (2.085 ms) : 2031, 2139
. : milestone, 2085,
section candidate
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (2.541 ms) : 2486, 2596
. : milestone, 2541,
iast (2.27 ms) : 2200, 2339
. : milestone, 2270,
iast_GLOBAL (2.308 ms) : 2239, 2378
. : milestone, 2308,
profiling (2.099 ms) : 2045, 2154
. : milestone, 2099,
tracing (2.095 ms) : 2040, 2149
. : milestone, 2095,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~bc787c05dc, baseline=1.62.0-SNAPSHOT~16f8277b2e
dateFormat X
axisFormat %s
section baseline
no_agent (15.387 s) : 15387000, 15387000
. : milestone, 15387000,
appsec (14.606 s) : 14606000, 14606000
. : milestone, 14606000,
iast (18.331 s) : 18331000, 18331000
. : milestone, 18331000,
iast_GLOBAL (18.027 s) : 18027000, 18027000
. : milestone, 18027000,
profiling (14.874 s) : 14874000, 14874000
. : milestone, 14874000,
tracing (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
section candidate
no_agent (15.127 s) : 15127000, 15127000
. : milestone, 15127000,
appsec (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
iast (18.293 s) : 18293000, 18293000
. : milestone, 18293000,
iast_GLOBAL (18.086 s) : 18086000, 18086000
. : milestone, 18086000,
profiling (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
tracing (14.973 s) : 14973000, 14973000
. : milestone, 14973000,
|
Test Environment - sonar-javaJob Status: success
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
passandfail, the test session was correctly failed.failandpass, the test session would incorrectly pass, while EFD should fail the session when a flaky is found.fail.Motivation
Aligns EFD behavior for TestNG with the rest of the testing frameworks.
Additional Information
Two unit tests have been introduced to verify the behavior.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: SDTEST-3720
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.