Migrate dd-trace-core groovy files to java part 3#11085
Open
Migrate dd-trace-core groovy files to java part 3#11085
Conversation
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
amarziali
reviewed
Apr 13, 2026
| expired = 0; | ||
| } | ||
|
|
||
| // @VisibleForTesting |
Contributor
There was a problem hiding this comment.
I'm wondering if we should import the real anno?
Contributor
There was a problem hiding this comment.
I agree that having a proper annotation should be suitable, but I wonder if we should create our own... Otherwise we depend on one of these deps:
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~15c6cdb2dc, baseline=1.62.0-SNAPSHOT~1ee99fb92c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050703
Total [baseline] (8.853 s) : 0, 8853040
Agent [candidate] (1.055 s) : 0, 1054857
Total [candidate] (8.833 s) : 0, 8833201
section iast
Agent [baseline] (1.22 s) : 0, 1219970
Total [baseline] (9.571 s) : 0, 9571158
Agent [candidate] (1.227 s) : 0, 1226941
Total [candidate] (9.534 s) : 0, 9533662
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~15c6cdb2dc, baseline=1.62.0-SNAPSHOT~1ee99fb92c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.238 ms) : 0, 1238
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (628.765 ms) : 0, 628765
BytebuddyAgent [candidate] (631.411 ms) : 0, 631411
AgentMeter [baseline] (29.27 ms) : 0, 29270
AgentMeter [candidate] (29.335 ms) : 0, 29335
GlobalTracer [baseline] (247.248 ms) : 0, 247248
GlobalTracer [candidate] (248.247 ms) : 0, 248247
AppSec [baseline] (32.232 ms) : 0, 32232
AppSec [candidate] (32.342 ms) : 0, 32342
Debugger [baseline] (59.065 ms) : 0, 59065
Debugger [candidate] (58.886 ms) : 0, 58886
Remote Config [baseline] (592.636 µs) : 0, 593
Remote Config [candidate] (576.936 µs) : 0, 577
Telemetry [baseline] (8.01 ms) : 0, 8010
Telemetry [candidate] (7.993 ms) : 0, 7993
Flare Poller [baseline] (8.206 ms) : 0, 8206
Flare Poller [candidate] (8.863 ms) : 0, 8863
section iast
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.231 ms) : 0, 1231
BytebuddyAgent [baseline] (798.179 ms) : 0, 798179
BytebuddyAgent [candidate] (804.088 ms) : 0, 804088
AgentMeter [baseline] (11.324 ms) : 0, 11324
AgentMeter [candidate] (11.628 ms) : 0, 11628
GlobalTracer [baseline] (238.739 ms) : 0, 238739
GlobalTracer [candidate] (238.684 ms) : 0, 238684
IAST [baseline] (25.724 ms) : 0, 25724
IAST [candidate] (25.757 ms) : 0, 25757
AppSec [baseline] (31.979 ms) : 0, 31979
AppSec [candidate] (29.806 ms) : 0, 29806
Debugger [baseline] (61.606 ms) : 0, 61606
Debugger [candidate] (62.588 ms) : 0, 62588
Remote Config [baseline] (1.141 ms) : 0, 1141
Remote Config [candidate] (1.156 ms) : 0, 1156
Telemetry [baseline] (10.618 ms) : 0, 10618
Telemetry [candidate] (12.067 ms) : 0, 12067
Flare Poller [baseline] (3.379 ms) : 0, 3379
Flare Poller [candidate] (3.461 ms) : 0, 3461
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~15c6cdb2dc, baseline=1.62.0-SNAPSHOT~1ee99fb92c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054637
Total [baseline] (10.99 s) : 0, 10989724
Agent [candidate] (1.057 s) : 0, 1057292
Total [candidate] (11.147 s) : 0, 11146625
section appsec
Agent [baseline] (1.245 s) : 0, 1244598
Total [baseline] (11.059 s) : 0, 11058627
Agent [candidate] (1.247 s) : 0, 1247192
Total [candidate] (11.141 s) : 0, 11140673
section iast
Agent [baseline] (1.239 s) : 0, 1238633
Total [baseline] (11.379 s) : 0, 11378551
Agent [candidate] (1.221 s) : 0, 1221358
Total [candidate] (11.249 s) : 0, 11249493
section profiling
Agent [baseline] (1.182 s) : 0, 1181607
Total [baseline] (11.023 s) : 0, 11023095
Agent [candidate] (1.185 s) : 0, 1184929
Total [candidate] (11.208 s) : 0, 11207697
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~15c6cdb2dc, baseline=1.62.0-SNAPSHOT~1ee99fb92c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (630.088 ms) : 0, 630088
BytebuddyAgent [candidate] (631.926 ms) : 0, 631926
AgentMeter [baseline] (29.384 ms) : 0, 29384
AgentMeter [candidate] (29.471 ms) : 0, 29471
GlobalTracer [baseline] (247.567 ms) : 0, 247567
GlobalTracer [candidate] (249.04 ms) : 0, 249040
AppSec [baseline] (32.204 ms) : 0, 32204
AppSec [candidate] (32.46 ms) : 0, 32460
Debugger [baseline] (59.72 ms) : 0, 59720
Debugger [candidate] (60.173 ms) : 0, 60173
Remote Config [baseline] (611.587 µs) : 0, 612
Remote Config [candidate] (598.094 µs) : 0, 598
Telemetry [baseline] (8.076 ms) : 0, 8076
Telemetry [candidate] (8.104 ms) : 0, 8104
Flare Poller [baseline] (9.779 ms) : 0, 9779
Flare Poller [candidate] (8.235 ms) : 0, 8235
section appsec
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.241 ms) : 0, 1241
BytebuddyAgent [baseline] (658.95 ms) : 0, 658950
BytebuddyAgent [candidate] (661.126 ms) : 0, 661126
AgentMeter [baseline] (12.035 ms) : 0, 12035
AgentMeter [candidate] (12.061 ms) : 0, 12061
GlobalTracer [baseline] (248.268 ms) : 0, 248268
GlobalTracer [candidate] (248.373 ms) : 0, 248373
IAST [baseline] (24.554 ms) : 0, 24554
IAST [candidate] (24.496 ms) : 0, 24496
AppSec [baseline] (184.904 ms) : 0, 184904
AppSec [candidate] (185.259 ms) : 0, 185259
Debugger [baseline] (65.728 ms) : 0, 65728
Debugger [candidate] (65.804 ms) : 0, 65804
Remote Config [baseline] (606.926 µs) : 0, 607
Remote Config [candidate] (623.72 µs) : 0, 624
Telemetry [baseline] (8.464 ms) : 0, 8464
Telemetry [candidate] (8.5 ms) : 0, 8500
Flare Poller [baseline] (3.527 ms) : 0, 3527
Flare Poller [candidate] (3.46 ms) : 0, 3460
section iast
crashtracking [baseline] (1.252 ms) : 0, 1252
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (808.135 ms) : 0, 808135
BytebuddyAgent [candidate] (799.05 ms) : 0, 799050
AgentMeter [baseline] (11.581 ms) : 0, 11581
AgentMeter [candidate] (11.35 ms) : 0, 11350
GlobalTracer [baseline] (242.71 ms) : 0, 242710
GlobalTracer [candidate] (238.613 ms) : 0, 238613
IAST [baseline] (26.552 ms) : 0, 26552
IAST [candidate] (25.791 ms) : 0, 25791
AppSec [baseline] (32.834 ms) : 0, 32834
AppSec [candidate] (30.412 ms) : 0, 30412
Debugger [baseline] (62.458 ms) : 0, 62458
Debugger [candidate] (61.991 ms) : 0, 61991
Remote Config [baseline] (565.053 µs) : 0, 565
Remote Config [candidate] (525.353 µs) : 0, 525
Telemetry [baseline] (12.553 ms) : 0, 12553
Telemetry [candidate] (12.604 ms) : 0, 12604
Flare Poller [baseline] (3.572 ms) : 0, 3572
Flare Poller [candidate] (3.601 ms) : 0, 3601
section profiling
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (689.177 ms) : 0, 689177
BytebuddyAgent [candidate] (689.95 ms) : 0, 689950
AgentMeter [baseline] (9.038 ms) : 0, 9038
AgentMeter [candidate] (9.114 ms) : 0, 9114
GlobalTracer [baseline] (206.658 ms) : 0, 206658
GlobalTracer [candidate] (208.132 ms) : 0, 208132
AppSec [baseline] (32.73 ms) : 0, 32730
AppSec [candidate] (32.838 ms) : 0, 32838
Debugger [baseline] (65.709 ms) : 0, 65709
Debugger [candidate] (66.005 ms) : 0, 66005
Remote Config [baseline] (578.37 µs) : 0, 578
Remote Config [candidate] (572.716 µs) : 0, 573
Telemetry [baseline] (7.782 ms) : 0, 7782
Telemetry [candidate] (7.851 ms) : 0, 7851
Flare Poller [baseline] (3.55 ms) : 0, 3550
Flare Poller [candidate] (3.594 ms) : 0, 3594
ProfilingAgent [baseline] (94.108 ms) : 0, 94108
ProfilingAgent [candidate] (94.575 ms) : 0, 94575
Profiling [baseline] (94.684 ms) : 0, 94684
Profiling [candidate] (95.136 ms) : 0, 95136
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~15c6cdb2dc, baseline=1.62.0-SNAPSHOT~1ee99fb92c
dateFormat X
axisFormat %s
section baseline
no_agent (1.361 ms) : 1348, 1374
. : milestone, 1361,
iast (3.594 ms) : 3546, 3642
. : milestone, 3594,
iast_FULL (6.583 ms) : 6513, 6653
. : milestone, 6583,
iast_GLOBAL (3.901 ms) : 3823, 3980
. : milestone, 3901,
profiling (2.243 ms) : 2223, 2263
. : milestone, 2243,
tracing (2.078 ms) : 2058, 2098
. : milestone, 2078,
section candidate
no_agent (1.397 ms) : 1383, 1411
. : milestone, 1397,
iast (3.809 ms) : 3750, 3867
. : milestone, 3809,
iast_FULL (6.408 ms) : 6341, 6475
. : milestone, 6408,
iast_GLOBAL (3.891 ms) : 3812, 3969
. : milestone, 3891,
profiling (2.202 ms) : 2183, 2222
. : milestone, 2202,
tracing (2.045 ms) : 2027, 2063
. : milestone, 2045,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~15c6cdb2dc, baseline=1.62.0-SNAPSHOT~1ee99fb92c
dateFormat X
axisFormat %s
section baseline
no_agent (20.081 ms) : 19877, 20285
. : milestone, 20081,
appsec (19.081 ms) : 18890, 19272
. : milestone, 19081,
code_origins (18.749 ms) : 18565, 18932
. : milestone, 18749,
iast (18.566 ms) : 18378, 18754
. : milestone, 18566,
profiling (19.312 ms) : 19118, 19506
. : milestone, 19312,
tracing (19.314 ms) : 19116, 19513
. : milestone, 19314,
section candidate
no_agent (18.74 ms) : 18549, 18932
. : milestone, 18740,
appsec (20.333 ms) : 20124, 20542
. : milestone, 20333,
code_origins (18.584 ms) : 18396, 18772
. : milestone, 18584,
iast (18.526 ms) : 18339, 18713
. : milestone, 18526,
profiling (19.279 ms) : 19084, 19475
. : milestone, 19279,
tracing (18.88 ms) : 18696, 19065
. : milestone, 18880,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~15c6cdb2dc, baseline=1.62.0-SNAPSHOT~1ee99fb92c
dateFormat X
axisFormat %s
section baseline
no_agent (1.497 ms) : 1485, 1508
. : milestone, 1497,
appsec (3.872 ms) : 3648, 4097
. : milestone, 3872,
iast (2.284 ms) : 2214, 2353
. : milestone, 2284,
iast_GLOBAL (2.331 ms) : 2261, 2400
. : milestone, 2331,
profiling (2.526 ms) : 2359, 2692
. : milestone, 2526,
tracing (2.084 ms) : 2031, 2137
. : milestone, 2084,
section candidate
no_agent (1.491 ms) : 1480, 1503
. : milestone, 1491,
appsec (3.811 ms) : 3591, 4031
. : milestone, 3811,
iast (2.274 ms) : 2205, 2343
. : milestone, 2274,
iast_GLOBAL (2.325 ms) : 2255, 2394
. : milestone, 2325,
profiling (2.112 ms) : 2057, 2167
. : milestone, 2112,
tracing (2.089 ms) : 2036, 2143
. : milestone, 2089,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~15c6cdb2dc, baseline=1.62.0-SNAPSHOT~1ee99fb92c
dateFormat X
axisFormat %s
section baseline
no_agent (15.641 s) : 15641000, 15641000
. : milestone, 15641000,
appsec (14.658 s) : 14658000, 14658000
. : milestone, 14658000,
iast (18.312 s) : 18312000, 18312000
. : milestone, 18312000,
iast_GLOBAL (17.991 s) : 17991000, 17991000
. : milestone, 17991000,
profiling (15.052 s) : 15052000, 15052000
. : milestone, 15052000,
tracing (14.713 s) : 14713000, 14713000
. : milestone, 14713000,
section candidate
no_agent (15.469 s) : 15469000, 15469000
. : milestone, 15469000,
appsec (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
iast (18.453 s) : 18453000, 18453000
. : milestone, 18453000,
iast_GLOBAL (17.853 s) : 17853000, 17853000
. : milestone, 17853000,
profiling (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
tracing (14.87 s) : 14870000, 14870000
. : milestone, 14870000,
|
bric3
reviewed
Apr 13, 2026
Contributor
bric3
left a comment
There was a problem hiding this comment.
I believe the configuration code is misusing WithConfigExtension.
| "128 bit traceid logging disabled | false " | ||
| }) | ||
| void shouldMuteTracing(String moreBits) throws Exception { | ||
| WithConfigExtension.injectSysConfig("trace.128.bit.traceid.logging.enabled", moreBits); |
Contributor
There was a problem hiding this comment.
issue: Shouldn't it have used WithConfig annotation, from #11076
Also, the skill should probably updated to use prefer WithConfig over WithConfigExtension.injectSysConfig
Member
Author
There was a problem hiding this comment.
Can you have an annotation based on parameter value of the method? I doubt it
Contributor
There was a problem hiding this comment.
No, that is supposed to use constants only.
The programmatic API is still there for this use case but I would recommend using static import for readability.
Comment on lines
+63
to
+66
| WithConfigExtension.injectSysConfig("trace.experimental.long-running.enabled", "true"); | ||
| WithConfigExtension.injectSysConfig( | ||
| "trace.experimental.long-running.initial.flush.interval", "10"); | ||
| WithConfigExtension.injectSysConfig("trace.experimental.long-running.flush.interval", "20"); |
Member
Author
There was a problem hiding this comment.
right those can be replaced with annotations
Member
Author
There was a problem hiding this comment.
but is it working on @BeforeEach setup method?
Contributor
PerfectSlayer
left a comment
There was a problem hiding this comment.
Left a bunch of comments to help with the migration
| - `@TableTest` and `@MethodSource` may be combined on the same `@ParameterizedTest` when most cases are tabular but a few cases require programmatic setup. | ||
| - In combined mode, keep table-friendly cases in `@TableTest`, and put only non-tabular/complex cases in `@MethodSource`. | ||
| - If `@TableTest` is not viable for the test at all, use `@MethodSource` only. | ||
| - If `@TableTest` was successfully used, `@ParameterizedTest` can then be removed as `@TableTest` replace it fully |
Contributor
There was a problem hiding this comment.
🔨 issue: Only if the @ParameterizedTest is not used to specify the test name.
Comment on lines
+17
to
+21
| @TableTest({ | ||
| "scenario | moreBits", | ||
| "128 bit traceid logging enabled | true ", | ||
| "128 bit traceid logging disabled | false " | ||
| }) |
Contributor
There was a problem hiding this comment.
🎯 suggestion: Can't we just have the 128-bit TID flag as parameter? There is no need for 2 columns here. We're only testing a flag.
| "128 bit traceid logging disabled | false " | ||
| }) | ||
| void shouldMuteTracing(String moreBits) throws Exception { | ||
| WithConfigExtension.injectSysConfig("trace.128.bit.traceid.logging.enabled", moreBits); |
Contributor
There was a problem hiding this comment.
No, that is supposed to use constants only.
The programmatic API is still there for this use case but I would recommend using static import for readability.
Comment on lines
+125
to
+128
| for (int i = 0; i < MAX_TRACKED_TRACES; i++) { | ||
| tracker.add(newTraceToTrack()); | ||
| } | ||
| tracker.add(newTraceToTrack()); |
Contributor
There was a problem hiding this comment.
💭 thought: Not very clear. Should it be a single loop with MAX + 1 instead?
| "128-bit enabled | true ", | ||
| "128-bit disabled | false " | ||
| }) | ||
| void getTraceIdWithoutTrace(boolean log128bTraceId) { |
Contributor
There was a problem hiding this comment.
🎯 suggestion: Same comment here. We can have a simple @ValueSource with "true" / "false".
| "128-bit enabled | true ", | ||
| "128-bit disabled | false " | ||
| }) | ||
| void getTraceIdWithTrace(boolean log128bTraceId) { |
Contributor
There was a problem hiding this comment.
🎯 suggestion: Same here
we migrate 3 small tests: - BlackholeSpanTest - LongRunningTracesTrackerTest - TraceCorrelationTest using new SpanConfigExtension for injecting config
0ae0065 to
15c6cdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
we migrate 3 small tests:
Motivation
this is part of the effort to migrate groovy tests to Java/JUnit
part1: #11053
part2: #11062
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.