Upgrade Spock version to 2.4#10168
Merged
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~d32293daf1, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078338
Total [baseline] (8.722 s) : 0, 8721698
Agent [candidate] (1.077 s) : 0, 1077029
Total [candidate] (8.813 s) : 0, 8812510
section iast
Agent [baseline] (1.22 s) : 0, 1219869
Total [baseline] (9.454 s) : 0, 9453745
Agent [candidate] (1.219 s) : 0, 1219100
Total [candidate] (9.481 s) : 0, 9480616
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~d32293daf1, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (646.96 ms) : 0, 646960
BytebuddyAgent [candidate] (646.428 ms) : 0, 646428
GlobalTracer [baseline] (281.403 ms) : 0, 281403
GlobalTracer [candidate] (281.622 ms) : 0, 281622
AppSec [baseline] (32.268 ms) : 0, 32268
AppSec [candidate] (32.349 ms) : 0, 32349
Debugger [baseline] (67.686 ms) : 0, 67686
Debugger [candidate] (66.851 ms) : 0, 66851
Remote Config [baseline] (658.472 µs) : 0, 658
Remote Config [candidate] (633.906 µs) : 0, 634
Telemetry [baseline] (9.031 ms) : 0, 9031
Telemetry [candidate] (8.871 ms) : 0, 8871
Flare Poller [baseline] (3.709 ms) : 0, 3709
Flare Poller [candidate] (3.643 ms) : 0, 3643
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (788.991 ms) : 0, 788991
BytebuddyAgent [candidate] (788.958 ms) : 0, 788958
GlobalTracer [baseline] (255.391 ms) : 0, 255391
GlobalTracer [candidate] (255.217 ms) : 0, 255217
AppSec [baseline] (35.019 ms) : 0, 35019
AppSec [candidate] (35.021 ms) : 0, 35021
Debugger [baseline] (64.683 ms) : 0, 64683
Debugger [candidate] (64.227 ms) : 0, 64227
Remote Config [baseline] (536.465 µs) : 0, 536
Remote Config [candidate] (540.614 µs) : 0, 541
Telemetry [baseline] (8.396 ms) : 0, 8396
Telemetry [candidate] (8.349 ms) : 0, 8349
Flare Poller [baseline] (3.46 ms) : 0, 3460
Flare Poller [candidate] (3.46 ms) : 0, 3460
IAST [baseline] (26.835 ms) : 0, 26835
IAST [candidate] (26.76 ms) : 0, 26760
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~d32293daf1, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1093717
Total [baseline] (10.855 s) : 0, 10855315
Agent [candidate] (1.079 s) : 0, 1079184
Total [candidate] (10.799 s) : 0, 10798522
section appsec
Agent [baseline] (1.262 s) : 0, 1261504
Total [baseline] (11.176 s) : 0, 11176104
Agent [candidate] (1.263 s) : 0, 1263159
Total [candidate] (11.088 s) : 0, 11087650
section iast
Agent [baseline] (1.238 s) : 0, 1238021
Total [baseline] (11.176 s) : 0, 11176067
Agent [candidate] (1.221 s) : 0, 1221485
Total [candidate] (11.181 s) : 0, 11181440
section profiling
Agent [baseline] (1.204 s) : 0, 1203653
Total [baseline] (10.967 s) : 0, 10967215
Agent [candidate] (1.211 s) : 0, 1211125
Total [candidate] (11.182 s) : 0, 11181504
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~d32293daf1, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (656.291 ms) : 0, 656291
BytebuddyAgent [candidate] (647.428 ms) : 0, 647428
GlobalTracer [baseline] (284.861 ms) : 0, 284861
GlobalTracer [candidate] (281.361 ms) : 0, 281361
AppSec [baseline] (32.783 ms) : 0, 32783
AppSec [candidate] (32.436 ms) : 0, 32436
Debugger [baseline] (69.279 ms) : 0, 69279
Debugger [candidate] (67.977 ms) : 0, 67977
Remote Config [baseline] (640.138 µs) : 0, 640
Remote Config [candidate] (663.104 µs) : 0, 663
Telemetry [baseline] (9.177 ms) : 0, 9177
Telemetry [candidate] (9.018 ms) : 0, 9018
Flare Poller [baseline] (3.832 ms) : 0, 3832
Flare Poller [candidate] (3.723 ms) : 0, 3723
section appsec
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (687.415 ms) : 0, 687415
BytebuddyAgent [candidate] (688.747 ms) : 0, 688747
GlobalTracer [baseline] (258.361 ms) : 0, 258361
GlobalTracer [candidate] (259.408 ms) : 0, 259408
AppSec [baseline] (174.391 ms) : 0, 174391
AppSec [candidate] (174.308 ms) : 0, 174308
Debugger [baseline] (66.7 ms) : 0, 66700
Debugger [candidate] (65.942 ms) : 0, 65942
Remote Config [baseline] (700.689 µs) : 0, 701
Remote Config [candidate] (702.918 µs) : 0, 703
Telemetry [baseline] (8.948 ms) : 0, 8948
Telemetry [candidate] (8.893 ms) : 0, 8893
Flare Poller [baseline] (3.839 ms) : 0, 3839
Flare Poller [candidate] (3.822 ms) : 0, 3822
IAST [baseline] (24.53 ms) : 0, 24530
IAST [candidate] (24.615 ms) : 0, 24615
section iast
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (801.807 ms) : 0, 801807
BytebuddyAgent [candidate] (789.545 ms) : 0, 789545
GlobalTracer [baseline] (258.531 ms) : 0, 258531
GlobalTracer [candidate] (255.569 ms) : 0, 255569
AppSec [baseline] (35.613 ms) : 0, 35613
AppSec [candidate] (34.236 ms) : 0, 34236
Debugger [baseline] (65.734 ms) : 0, 65734
Debugger [candidate] (66.474 ms) : 0, 66474
Remote Config [baseline] (541.334 µs) : 0, 541
Remote Config [candidate] (532.891 µs) : 0, 533
Telemetry [baseline] (8.372 ms) : 0, 8372
Telemetry [candidate] (8.428 ms) : 0, 8428
Flare Poller [baseline] (3.44 ms) : 0, 3440
Flare Poller [candidate] (3.451 ms) : 0, 3451
IAST [baseline] (27.245 ms) : 0, 27245
IAST [candidate] (26.798 ms) : 0, 26798
section profiling
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (701.481 ms) : 0, 701481
BytebuddyAgent [candidate] (705.844 ms) : 0, 705844
GlobalTracer [baseline] (220.716 ms) : 0, 220716
GlobalTracer [candidate] (222.117 ms) : 0, 222117
AppSec [baseline] (32.219 ms) : 0, 32219
AppSec [candidate] (32.794 ms) : 0, 32794
Debugger [baseline] (67.806 ms) : 0, 67806
Debugger [candidate] (68.448 ms) : 0, 68448
Remote Config [baseline] (645.534 µs) : 0, 646
Remote Config [candidate] (645.321 µs) : 0, 645
Telemetry [baseline] (8.993 ms) : 0, 8993
Telemetry [candidate] (9.131 ms) : 0, 9131
Flare Poller [baseline] (3.78 ms) : 0, 3780
Flare Poller [candidate] (3.81 ms) : 0, 3810
ProfilingAgent [baseline] (97.351 ms) : 0, 97351
ProfilingAgent [candidate] (97.602 ms) : 0, 97602
Profiling [baseline] (97.94 ms) : 0, 97940
Profiling [candidate] (98.177 ms) : 0, 98177
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~d32293daf1, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section baseline
no_agent (18.956 ms) : 18760, 19153
. : milestone, 18956,
appsec (18.492 ms) : 18311, 18673
. : milestone, 18492,
code_origins (17.723 ms) : 17542, 17903
. : milestone, 17723,
iast (17.642 ms) : 17469, 17815
. : milestone, 17642,
profiling (18.902 ms) : 18712, 19092
. : milestone, 18902,
tracing (17.937 ms) : 17760, 18113
. : milestone, 17937,
section candidate
no_agent (17.158 ms) : 16984, 17331
. : milestone, 17158,
appsec (18.728 ms) : 18538, 18918
. : milestone, 18728,
code_origins (17.601 ms) : 17425, 17778
. : milestone, 17601,
iast (17.71 ms) : 17532, 17887
. : milestone, 17710,
profiling (19.605 ms) : 19404, 19806
. : milestone, 19605,
tracing (17.837 ms) : 17658, 18015
. : milestone, 17837,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~d32293daf1, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section baseline
no_agent (1.203 ms) : 1191, 1215
. : milestone, 1203,
iast (3.248 ms) : 3208, 3288
. : milestone, 3248,
iast_FULL (6.073 ms) : 6012, 6134
. : milestone, 6073,
iast_GLOBAL (3.634 ms) : 3577, 3692
. : milestone, 3634,
profiling (2.145 ms) : 2124, 2167
. : milestone, 2145,
tracing (1.774 ms) : 1759, 1790
. : milestone, 1774,
section candidate
no_agent (1.208 ms) : 1196, 1220
. : milestone, 1208,
iast (3.32 ms) : 3280, 3360
. : milestone, 3320,
iast_FULL (6.0 ms) : 5939, 6061
. : milestone, 6000,
iast_GLOBAL (3.619 ms) : 3563, 3675
. : milestone, 3619,
profiling (2.095 ms) : 2076, 2114
. : milestone, 2095,
tracing (1.792 ms) : 1777, 1807
. : milestone, 1792,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~d32293daf1, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section baseline
no_agent (15.489 s) : 15489000, 15489000
. : milestone, 15489000,
appsec (14.689 s) : 14689000, 14689000
. : milestone, 14689000,
iast (18.63 s) : 18630000, 18630000
. : milestone, 18630000,
iast_GLOBAL (17.945 s) : 17945000, 17945000
. : milestone, 17945000,
profiling (14.668 s) : 14668000, 14668000
. : milestone, 14668000,
tracing (14.65 s) : 14650000, 14650000
. : milestone, 14650000,
section candidate
no_agent (15.475 s) : 15475000, 15475000
. : milestone, 15475000,
appsec (14.674 s) : 14674000, 14674000
. : milestone, 14674000,
iast (18.28 s) : 18280000, 18280000
. : milestone, 18280000,
iast_GLOBAL (17.767 s) : 17767000, 17767000
. : milestone, 17767000,
profiling (14.673 s) : 14673000, 14673000
. : milestone, 14673000,
tracing (14.687 s) : 14687000, 14687000
. : milestone, 14687000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~d32293daf1, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.461 ms) : 2409, 2513
. : milestone, 2461,
iast (2.208 ms) : 2144, 2273
. : milestone, 2208,
iast_GLOBAL (2.251 ms) : 2186, 2316
. : milestone, 2251,
profiling (2.06 ms) : 2008, 2113
. : milestone, 2060,
tracing (2.042 ms) : 1991, 2093
. : milestone, 2042,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.697 ms) : 3479, 3916
. : milestone, 3697,
iast (2.208 ms) : 2144, 2272
. : milestone, 2208,
iast_GLOBAL (2.25 ms) : 2185, 2315
. : milestone, 2250,
profiling (2.084 ms) : 2030, 2139
. : milestone, 2084,
tracing (2.049 ms) : 1998, 2100
. : milestone, 2049,
|
AlexeyKuznetsov-DD
approved these changes
Dec 12, 2025
bric3
approved these changes
Dec 12, 2025
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
nikita-tkachenko-datadog
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
.with {}together with assertions in tests due to breaking changes in the releaseMotivation
2.4version of Spock introduced breaking changes. In particular,org.spockframework.lang.SpecInternalswas refactored toorg.spockframework.runtime.SpecInternals. This class is effectively extended by ourDDSpecification, causing issues when testing Spock instrumentation due to the tests being compiled with a different version than the one used to run them.Additional Notes
test_successful_maven_run_junit_platform_runnerproject inMavenSmokeTestand through Test Optimization's test environment.Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]