Fix race condition Exception Replay smoke tests#10011
Conversation
need to wait for having added the fingerprint into the Concurrent Map otherwise it will try to reinstrument the exception on the second call Generalize the usage of NonRetryable annotation because all debugger smoke tests rely on the fact that they are run only once (log file naming)
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (326.805 µs) : 293, 361
. : milestone, 327,
basic (292.338 µs) : 285, 300
. : milestone, 292,
loop (8.44 ms) : 8378, 8502
. : milestone, 8440,
section candidate
noprobe (326.787 µs) : 283, 370
. : milestone, 327,
basic (292.368 µs) : 285, 300
. : milestone, 292,
loop (8.447 ms) : 8385, 8509
. : milestone, 8447,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~b8761e406b, baseline=1.57.0-SNAPSHOT~6b32bddf07
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.111 s) : 0, 1111307
Total [baseline] (10.847 s) : 0, 10847370
Agent [candidate] (1.109 s) : 0, 1108886
Total [candidate] (10.81 s) : 0, 10810363
section appsec
Agent [baseline] (1.287 s) : 0, 1286773
Total [baseline] (11.121 s) : 0, 11120793
Agent [candidate] (1.279 s) : 0, 1278569
Total [candidate] (11.115 s) : 0, 11114765
section iast
Agent [baseline] (1.245 s) : 0, 1245331
Total [baseline] (11.319 s) : 0, 11319246
Agent [candidate] (1.24 s) : 0, 1240201
Total [candidate] (11.277 s) : 0, 11277035
section profiling
Agent [baseline] (1.233 s) : 0, 1232886
Total [baseline] (11.057 s) : 0, 11056703
Agent [candidate] (1.232 s) : 0, 1231674
Total [candidate] (11.128 s) : 0, 11127996
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~b8761e406b, baseline=1.57.0-SNAPSHOT~6b32bddf07
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (713.76 ms) : 0, 713760
BytebuddyAgent [candidate] (712.653 ms) : 0, 712653
GlobalTracer [baseline] (251.636 ms) : 0, 251636
GlobalTracer [candidate] (250.479 ms) : 0, 250479
AppSec [baseline] (32.214 ms) : 0, 32214
AppSec [candidate] (32.252 ms) : 0, 32252
Debugger [baseline] (64.546 ms) : 0, 64546
Debugger [candidate] (64.272 ms) : 0, 64272
Remote Config [baseline] (633.657 µs) : 0, 634
Remote Config [candidate] (636.431 µs) : 0, 636
Telemetry [baseline] (8.355 ms) : 0, 8355
Telemetry [candidate] (8.419 ms) : 0, 8419
Flare Poller [baseline] (3.782 ms) : 0, 3782
Flare Poller [candidate] (3.787 ms) : 0, 3787
section appsec
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (734.421 ms) : 0, 734421
BytebuddyAgent [candidate] (730.767 ms) : 0, 730767
GlobalTracer [baseline] (241.687 ms) : 0, 241687
GlobalTracer [candidate] (239.978 ms) : 0, 239978
AppSec [baseline] (174.535 ms) : 0, 174535
AppSec [candidate] (173.178 ms) : 0, 173178
Debugger [baseline] (61.936 ms) : 0, 61936
Debugger [candidate] (61.08 ms) : 0, 61080
Remote Config [baseline] (670.231 µs) : 0, 670
Remote Config [candidate] (655.18 µs) : 0, 655
Telemetry [baseline] (8.224 ms) : 0, 8224
Telemetry [candidate] (8.063 ms) : 0, 8063
Flare Poller [baseline] (3.886 ms) : 0, 3886
Flare Poller [candidate] (3.878 ms) : 0, 3878
IAST [baseline] (25.034 ms) : 0, 25034
IAST [candidate] (24.614 ms) : 0, 24614
section iast
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (834.931 ms) : 0, 834931
BytebuddyAgent [candidate] (832.018 ms) : 0, 832018
GlobalTracer [baseline] (238.791 ms) : 0, 238791
GlobalTracer [candidate] (237.673 ms) : 0, 237673
AppSec [baseline] (33.459 ms) : 0, 33459
AppSec [candidate] (33.167 ms) : 0, 33167
Debugger [baseline] (61.403 ms) : 0, 61403
Debugger [candidate] (60.877 ms) : 0, 60877
Remote Config [baseline] (557.451 µs) : 0, 557
Remote Config [candidate] (541.168 µs) : 0, 541
Telemetry [baseline] (7.708 ms) : 0, 7708
Telemetry [candidate] (7.595 ms) : 0, 7595
Flare Poller [baseline] (3.551 ms) : 0, 3551
Flare Poller [candidate] (3.498 ms) : 0, 3498
IAST [baseline] (28.601 ms) : 0, 28601
IAST [candidate] (28.427 ms) : 0, 28427
section profiling
ProfilingAgent [baseline] (97.195 ms) : 0, 97195
ProfilingAgent [candidate] (96.91 ms) : 0, 96910
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (734.811 ms) : 0, 734811
BytebuddyAgent [candidate] (734.444 ms) : 0, 734444
GlobalTracer [baseline] (221.994 ms) : 0, 221994
GlobalTracer [candidate] (222.126 ms) : 0, 222126
AppSec [baseline] (32.142 ms) : 0, 32142
AppSec [candidate] (32.249 ms) : 0, 32249
Debugger [baseline] (63.574 ms) : 0, 63574
Debugger [candidate] (63.076 ms) : 0, 63076
Remote Config [baseline] (656.156 µs) : 0, 656
Remote Config [candidate] (666.84 µs) : 0, 667
Telemetry [baseline] (8.133 ms) : 0, 8133
Telemetry [candidate] (8.02 ms) : 0, 8020
Flare Poller [baseline] (3.782 ms) : 0, 3782
Flare Poller [candidate] (3.707 ms) : 0, 3707
Profiling [baseline] (97.786 ms) : 0, 97786
Profiling [candidate] (97.508 ms) : 0, 97508
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~b8761e406b, baseline=1.57.0-SNAPSHOT~6b32bddf07
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.105 s) : 0, 1105344
Total [baseline] (8.847 s) : 0, 8846924
Agent [candidate] (1.1 s) : 0, 1099625
Total [candidate] (8.826 s) : 0, 8825851
section iast
Agent [baseline] (1.239 s) : 0, 1238946
Total [baseline] (9.534 s) : 0, 9534437
Agent [candidate] (1.249 s) : 0, 1249494
Total [candidate] (9.61 s) : 0, 9609821
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~b8761e406b, baseline=1.57.0-SNAPSHOT~6b32bddf07
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (710.508 ms) : 0, 710508
BytebuddyAgent [candidate] (706.632 ms) : 0, 706632
GlobalTracer [baseline] (249.368 ms) : 0, 249368
GlobalTracer [candidate] (249.076 ms) : 0, 249076
AppSec [baseline] (32.245 ms) : 0, 32245
AppSec [candidate] (32.011 ms) : 0, 32011
Debugger [baseline] (64.036 ms) : 0, 64036
Debugger [candidate] (62.985 ms) : 0, 62985
Remote Config [baseline] (645.132 µs) : 0, 645
Remote Config [candidate] (633.099 µs) : 0, 633
Telemetry [baseline] (8.387 ms) : 0, 8387
Telemetry [candidate] (8.358 ms) : 0, 8358
Flare Poller [baseline] (3.801 ms) : 0, 3801
Flare Poller [candidate] (3.692 ms) : 0, 3692
section iast
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (831.478 ms) : 0, 831478
BytebuddyAgent [candidate] (839.314 ms) : 0, 839314
GlobalTracer [baseline] (237.405 ms) : 0, 237405
GlobalTracer [candidate] (239.529 ms) : 0, 239529
IAST [baseline] (28.428 ms) : 0, 28428
IAST [candidate] (28.862 ms) : 0, 28862
AppSec [baseline] (33.206 ms) : 0, 33206
AppSec [candidate] (33.178 ms) : 0, 33178
Debugger [baseline] (60.345 ms) : 0, 60345
Debugger [candidate] (60.436 ms) : 0, 60436
Remote Config [baseline] (539.284 µs) : 0, 539
Remote Config [candidate] (545.587 µs) : 0, 546
Telemetry [baseline] (7.639 ms) : 0, 7639
Telemetry [candidate] (7.66 ms) : 0, 7660
Flare Poller [baseline] (3.547 ms) : 0, 3547
Flare Poller [candidate] (3.487 ms) : 0, 3487
LoadParameters
See matching parameters
SummaryFound 7 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~b8761e406b, baseline=1.57.0-SNAPSHOT~6b32bddf07
dateFormat X
axisFormat %s
section baseline
no_agent (1.198 ms) : 1186, 1209
. : milestone, 1198,
iast (3.367 ms) : 3318, 3417
. : milestone, 3367,
iast_FULL (6.208 ms) : 6144, 6271
. : milestone, 6208,
iast_GLOBAL (3.562 ms) : 3506, 3618
. : milestone, 3562,
profiling (2.262 ms) : 2242, 2282
. : milestone, 2262,
tracing (1.837 ms) : 1822, 1853
. : milestone, 1837,
section candidate
no_agent (1.219 ms) : 1207, 1230
. : milestone, 1219,
iast (3.143 ms) : 3098, 3189
. : milestone, 3143,
iast_FULL (5.831 ms) : 5772, 5889
. : milestone, 5831,
iast_GLOBAL (3.699 ms) : 3637, 3761
. : milestone, 3699,
profiling (2.365 ms) : 2341, 2390
. : milestone, 2365,
tracing (1.914 ms) : 1896, 1932
. : milestone, 1914,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~b8761e406b, baseline=1.57.0-SNAPSHOT~6b32bddf07
dateFormat X
axisFormat %s
section baseline
no_agent (19.322 ms) : 19121, 19524
. : milestone, 19322,
appsec (19.524 ms) : 19324, 19723
. : milestone, 19524,
code_origins (17.629 ms) : 17451, 17807
. : milestone, 17629,
iast (17.57 ms) : 17398, 17742
. : milestone, 17570,
profiling (18.602 ms) : 18416, 18789
. : milestone, 18602,
tracing (17.584 ms) : 17406, 17762
. : milestone, 17584,
section candidate
no_agent (16.875 ms) : 16707, 17043
. : milestone, 16875,
appsec (18.455 ms) : 18269, 18640
. : milestone, 18455,
code_origins (17.829 ms) : 17648, 18010
. : milestone, 17829,
iast (17.583 ms) : 17409, 17757
. : milestone, 17583,
profiling (18.658 ms) : 18473, 18843
. : milestone, 18658,
tracing (17.483 ms) : 17300, 17666
. : milestone, 17483,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~b8761e406b, baseline=1.57.0-SNAPSHOT~6b32bddf07
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.725 ms) : 3505, 3945
. : milestone, 3725,
iast (2.225 ms) : 2160, 2290
. : milestone, 2225,
iast_GLOBAL (2.261 ms) : 2196, 2326
. : milestone, 2261,
profiling (2.066 ms) : 2013, 2118
. : milestone, 2066,
tracing (2.053 ms) : 2002, 2104
. : milestone, 2053,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.708 ms) : 3490, 3927
. : milestone, 3708,
iast (2.215 ms) : 2151, 2280
. : milestone, 2215,
iast_GLOBAL (2.269 ms) : 2204, 2334
. : milestone, 2269,
profiling (2.073 ms) : 2021, 2125
. : milestone, 2073,
tracing (2.046 ms) : 1995, 2097
. : milestone, 2046,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~b8761e406b, baseline=1.57.0-SNAPSHOT~6b32bddf07
dateFormat X
axisFormat %s
section baseline
no_agent (14.947 s) : 14947000, 14947000
. : milestone, 14947000,
appsec (14.825 s) : 14825000, 14825000
. : milestone, 14825000,
iast (18.284 s) : 18284000, 18284000
. : milestone, 18284000,
iast_GLOBAL (17.745 s) : 17745000, 17745000
. : milestone, 17745000,
profiling (14.704 s) : 14704000, 14704000
. : milestone, 14704000,
tracing (14.962 s) : 14962000, 14962000
. : milestone, 14962000,
section candidate
no_agent (15.476 s) : 15476000, 15476000
. : milestone, 15476000,
appsec (14.979 s) : 14979000, 14979000
. : milestone, 14979000,
iast (18.708 s) : 18708000, 18708000
. : milestone, 18708000,
iast_GLOBAL (17.895 s) : 17895000, 17895000
. : milestone, 17895000,
profiling (14.756 s) : 14756000, 14756000
. : milestone, 14756000,
tracing (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
|
bric3
left a comment
There was a problem hiding this comment.
Looks good, but another pair of eyes working on this part of the codebase could be useful
What Does This Do
need to wait for having added the fingerprint into the Concurrent Map otherwise it will try to reinstrument the exception on the second call Generalize the usage of NonRetryable annotation because all debugger smoke tests rely on the fact that they are run only once (log file naming)
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]