remove commented json so dnx tooling doesn't break#310
Merged
Conversation
|
Along with the comments in the project.json file causing problems, I'm pretty sure the two project.lock.json (in Dapper and Dapper.DNX.Test) files should be removed from source control and would need to be part of the gitignore. |
mgravell
added a commit
that referenced
this pull request
Aug 25, 2015
remove commented json so dnx tooling doesn't break
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These comments break dnu out of the box, and there isn't any .net 3.5 support planned for dnx, so I recommend just removing these.