Repository navigation
Conversation
Align the rule ID with the sshd_* naming convention used by sibling OpenSSH server rules and update all in-repo references. Assisted-by: Cursor Signed-off-by: sluetze <13255307+sluetze@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi @sluetze. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
lint failures are on unchanged lines, just because the files werent touched for a long time. I am fine fixing these, if needed. please say so if required. |
|
do we actually need this change? it does not follow the pattern, but actually changing it now causes more issues than solves it. A renamed rule means any new versions people won't be able to re-use their tailoring files. Backwards compatibility just goes away. |
|
if renaming can be done this lightly, then it is time to do this: |
I forgot, that the tailoring files refer to the rules using the same name. Thats a valid point, and obviously the drawbacks are too high in this case. |
Align the rule ID with the sshd_* naming convention used by sibling OpenSSH server rules and update all in-repo references.
Assisted-by: Cursor
Description:
This change is basically
sed -i 's/disable_host_auth/sshd_disable_host_auth/g'Rationale:
all other sshd rules are named the same way. this one not, so it does not follow the naming convention.
Utilizing
/find-rulefor a related project, I consistently got AI tripping over this inconsistent naming.naming it consistently also increases readability of control files, as it is directly obvious, that host-auth is disabled in sshd, and not for other services.
Review Hints:
there is no real content change, only naming of the rules. should be transparent to the toolings. Will trip-over rule-references outside of this repository, i.e. which are defined in oscal-props.