template: kernel_module_disabled, use rule_id in OVAL definition name#14787
Open
vojtapolasek wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
This issue was discovered when per-rule tests started failing after #14763 got merged. |
|
@vojtapolasek: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
kernel_module_disabledtemplate OVAL definition to use the built-in_RULE_IDJinja variable for the OVAL definitionidattribute instead of constructing it from theKERNMODULEparameter.Rationale:
kernel_module_{KERNMODULE}_disableddid not always match the actual rule ID that uses the template. Using_RULE_IDensures the OVAL definition name is consistent with the rule that instantiates it, which is the standard convention used by other templates.Review Hints:
shared/templates/kernel_module_disabled/oval.template.kernel_module_disabledrules to verify no build regressions:./build_product --datastream-only rhel9kernel_module_<modname>_disabled.