Skip to content

template: kernel_module_disabled, use rule_id in OVAL definition name#14787

Open
vojtapolasek wants to merge 1 commit into
ComplianceAsCode:masterfrom
vojtapolasek:fix_kernel_module_disabled_template_oval_name
Open

template: kernel_module_disabled, use rule_id in OVAL definition name#14787
vojtapolasek wants to merge 1 commit into
ComplianceAsCode:masterfrom
vojtapolasek:fix_kernel_module_disabled_template_oval_name

Conversation

@vojtapolasek
Copy link
Copy Markdown
Collaborator

Description:

  • Modify the kernel_module_disabled template OVAL definition to use the built-in _RULE_ID Jinja variable for the OVAL definition id attribute instead of constructing it from the KERNMODULE parameter.

Rationale:

  • The previous OVAL definition ID kernel_module_{KERNMODULE}_disabled did not always match the actual rule ID that uses the template. Using _RULE_ID ensures the OVAL definition name is consistent with the rule that instantiates it, which is the standard convention used by other templates.

Review Hints:

  • Single-line change in shared/templates/kernel_module_disabled/oval.template.
  • Build any product that uses kernel_module_disabled rules to verify no build regressions: ./build_product --datastream-only rhel9
  • Check that OVAL definitions in the built data stream now use the rule ID as definition name instead of kernel_module_<modname>_disabled.

@vojtapolasek vojtapolasek added this to the 0.1.82 milestone Jun 8, 2026
@vojtapolasek vojtapolasek added OVAL OVAL update. Related to the systems assessments. Update Template Issues or pull requests related to Templates updates. labels Jun 8, 2026
@vojtapolasek
Copy link
Copy Markdown
Collaborator Author

This issue was discovered when per-rule tests started failing after #14763 got merged.

@Arden97 Arden97 self-assigned this Jun 8, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 8, 2026

@vojtapolasek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.21-images 5dd1358 link true /test 4.21-images
ci/prow/4.20-images 5dd1358 link true /test 4.20-images
ci/prow/e2e-aws-openshift-node-compliance 5dd1358 link true /test e2e-aws-openshift-node-compliance
ci/prow/e2e-aws-openshift-platform-compliance 5dd1358 link true /test e2e-aws-openshift-platform-compliance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OVAL OVAL update. Related to the systems assessments. Update Template Issues or pull requests related to Templates updates.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants