Add Debian 13 package and service name overrides for CIS section 2#14779
Open
israel-villar wants to merge 1 commit into
Open
Add Debian 13 package and service name overrides for CIS section 2#14779israel-villar wants to merge 1 commit into
israel-villar wants to merge 1 commit into
Conversation
Extend existing service-disable and package-remove rules to support Debian 13 by adding pkgname@debian13 and servicename@debian13 overrides, and extending 'ubuntu' conditions to cover 'debian' products: - avahi: pkgname@debian13=avahi-daemon, packagename@debian13=avahi-daemon - bind: pkgname@debian13=bind9, packagename@debian13=bind9 - httpd/apache2: extend ubuntu condition to debian (package=apache2, service=apache2) - dovecot: pkgname@debian13=dovecot-core, packagename@debian13=dovecot-core - openldap-clients: pkgname@debian13=ldap-utils - openldap-servers/slapd: pkgname@debian13=slapd, packagename@debian13=slapd - nfs: packagename@debian13=nfs-kernel-server - rsh: pkgname@debian13=rsh-client, extend ubuntu condition to debian - rsyncd: packagename@debian13=rsync, servicename@debian13=rsync - tftp: extend ubuntu condition to debian (package/service=tftpd-hpa) - smb/samba: servicename@debian13=smbd - snmp: pkgname@debian13=snmpd, packagename@debian13=snmpd - xorg: pkgname@debian13=xserver-common - gdm: pkgname@debian13=gdm3, extend ubuntu condition to debian - service_disabled_guard_var template: add multi_platform_debian to the platform line so chrony/timesyncd guard rules apply to Debian Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hi @israel-villar. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend existing service-disable and package-remove rules to support Debian 13 by adding pkgname@debian13 and servicename@debian13 overrides, and extending 'ubuntu' conditions to cover 'debian' products:
Description:
Extend existing service-disable and package-remove rules to support
Debian 13 by adding
pkgname@debian13andservicename@debian13overrides, and widening
'ubuntu' in productguards to cover'debian' in productwhere needed:avahi-daemonbind9apache2, service=apache2)dovecot-coreldap-utilsslapdnfs-kernel-serverrsh-client; extend ubuntu → debianrsync, service=rsynctftpd-hpa)smbdsnmpdxserver-commongdm3; extend ubuntu → debianservice_disabled_guard_varbash template: addmulti_platform_debianso the chrony/timesyncd guard logic applies to Debian products.
Rationale:
Without these overrides the
package_removedandservice_disabledtemplates fall back to RHEL package/service names, causing incorrect
checks and remediations on Debian 13.
Review Hints:
All changes are additive overrides or condition extensions — no existing
RHEL/Ubuntu behaviour is modified. The
service_disabled_guard_vartemplate change adds Debian to the platform list so that the
chronyd_or_timesyncdguard runs correctly on Debian 13.