Skip to content

Make ImageUpscaleWithModel node work with intermediate device and dtype.#13357

Merged
comfyanonymous merged 1 commit intomasterfrom
temp_pr
Apr 11, 2026
Merged

Make ImageUpscaleWithModel node work with intermediate device and dtype.#13357
comfyanonymous merged 1 commit intomasterfrom
temp_pr

Conversation

@comfyanonymous
Copy link
Copy Markdown
Member

@comfyanonymous comfyanonymous commented Apr 11, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 752959ec-002e-4957-bb7e-1f06a450c4ca

📥 Commits

Reviewing files that changed from the base of the PR and between a134423 and d854a6c.

📒 Files selected for processing (1)
  • comfy_extras/nodes_upscale_model.py
📝 Walkthrough

Walkthrough

The pull request modifies the upscale model node to add explicit device and dtype management. An import for comfy.model_management is added, and the execute method now queries for an intermediate device that gets passed to the tiled scaling function. The upscale model invocation is updated to convert input tensors to float precision, and output tensors are converted to the intermediate dtype before returning.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, so the description is empty. Consider adding a description explaining the motivation, context, or impact of these changes for better clarity.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: making the ImageUpscaleWithModel node compatible with intermediate device and dtype management.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@comfyanonymous comfyanonymous merged commit a2840e7 into master Apr 11, 2026
16 checks passed
@comfyanonymous comfyanonymous deleted the temp_pr branch April 11, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kosinkadink Kosinkadink Awaiting requested review from Kosinkadink Kosinkadink is a code owner

@guill guill Awaiting requested review from guill guill is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@comfyanonymous