Fix compatibility with symfony/dom-crawler < 5.3.0-BETA-1#50
Merged
TavoNiievez merged 1 commit intoCodeception:masterfrom Jan 27, 2022
Merged
Fix compatibility with symfony/dom-crawler < 5.3.0-BETA-1#50TavoNiievez merged 1 commit intoCodeception:masterfrom
TavoNiievez merged 1 commit intoCodeception:masterfrom
Conversation
TavoNiievez
approved these changes
Jan 26, 2022
Member
TavoNiievez
left a comment
There was a problem hiding this comment.
I think the docblock you added is pretty well explained.
|
@TavoNiievez Any idea of a release date for 2.0.2? This is blocking us from upgrading our dependencies. |
Member
|
@KyleWardle Right now ;-) |
No worries at all, appreciate the quick response, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49
Wasn't sure how best to add a unit test for this, happy to update if there's a good way to do so.
@TavoNiievez FYI