Include mock expectations in assertion count #6672
Merged
DavertMik merged 2 commits intoCodeception:5.0from Jun 6, 2023
Merged
Include mock expectations in assertion count #6672DavertMik merged 2 commits intoCodeception:5.0from
DavertMik merged 2 commits intoCodeception:5.0from
Conversation
This fixes the problem that the mock expectations count was not included in the assertion count.
881f260 to
ca1e3b5
Compare
Arhell
approved these changes
Jun 6, 2023
DavertMik
approved these changes
Jun 6, 2023
Member
|
Looks good to me! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #6671.
The fix works for both PHPUnit and Codeception mocking methods. It also works when using a external mocking library like Mockery.