Repository navigation
fix #3866 grabValueFrom doesn't work with fillField - #3873
Merged
Naktibalda merged 1 commit intoDec 30, 2016
Merged
Conversation
Contributor
Author
DavertMik
reviewed
Dec 27, 2016
| $result = $this->module->grabValueFrom('#age'); | ||
| $this->assertEquals('oldfag', $result); | ||
|
|
||
| $this->module->amOnPage('/form/bug3866'); |
Member
There was a problem hiding this comment.
big thanks for this PR, and especially for test, but could you move this to separate test so it would be easier to find it? Thanks
wumouse
force-pushed
the
correct-grab-value-from-with-fill-field
branch
from
December 28, 2016 04:10
a656d5d to
8b45ec4
Compare
Contributor
Author
|
@DavertMik Please review the new commit, thank you |
Naktibalda
approved these changes
Dec 29, 2016
Naktibalda
left a comment
Member
There was a problem hiding this comment.
Thanks, your change looks good.
Does it fix seeInField too?
Contributor
Author
|
@Naktibalda Yes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue 3866