London | ITP-May-2026 | Carolina Villa | Sprint 1 | Form Task#1295
London | ITP-May-2026 | Carolina Villa | Sprint 1 | Form Task#1295caro-vh wants to merge 12 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| name="full-name" | ||
| required | ||
| minlength="2" | ||
| pattern=".*\S,*\S.*" |
There was a problem hiding this comment.
Can you change this pattern so that it can also accept a name like "C J" (two characters separated by a space)?
There was a problem hiding this comment.
Thanks for the review, I'll have a look and fix it.
| <input type="radio" id="red" name="colour" value="red" required> | ||
| <label for="red">red</label> |
There was a problem hiding this comment.
Note: If you wrap the <input> element inside <label>, you would not need to introduce id.
There was a problem hiding this comment.
I see, I thought it was necessary for an easier manipulation in CSS, thank you for letting me know
|
Can you edit the PR description so that the "Changelist" word is a level-2 header instead of a normal paragraph? Changelistinstead of Changelist |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good, but it seems you have accidently included the "GitHomeworkFixErrors" folder in your "Module-Onboarding" folder (on this branch). You need to remove that folder or move that folder out of your "Module-Onboarding" folder to keep this branch clean. Otherwise the Validation bot will reject your PR.
|
Thank you for letting me know, I'll fix it |
This comment has been minimized.
This comment has been minimized.
| </body> | ||
|
|
||
| </html> No newline at end of file |
There was a problem hiding this comment.
It seems the code is manually indented.
You may want to follow this guide and
enable "Format on Save" in VS Code or use VS Code's "Format Document" feature to keep your code consistently formatted. It could save you some time.
Self checklist
Changelist
Used form controls to collect customers data, such as t-shirt colour and size.