Skip to content

Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 1 | Hashtag slowing down my browser #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enjoy15 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 1 | Hashtag slowing down my browser #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion front-end/views/hashtag.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,15 @@ import {createHeading} from "../components/heading.mjs";
function hashtagView(hashtag) {
destroy();

apiService.getBloomsByHashtag(hashtag);
// Normalise to the same shape the API stores in state (e.g. "do" -> "#do")
const normalisedTag = `#${hashtag.startsWith("#") ? hashtag.substring(1) : hashtag}`;

// Only fetch if this hashtag isn't already loaded. Without this guard,
// every render fetches -> updates state -> fires "state-change" -> re-renders,
// an infinite loop that flashes the page blank and hangs the browser.
if (state.currentHashtag !== normalisedTag) {
apiService.getBloomsByHashtag(hashtag);
}

renderOne(
state.isLoggedIn,
Expand Down