West Midlands | 26 March SDC | Iswat Bello | Sprint 1 | Purple Forest/bug report/Hashtag link doesn't work#211
Open
Iswanna wants to merge 1 commit into
Conversation
Restrict hashtag parsing in bloom.mjs from /\B#[^#]+/g to /\B#[\w]+/g so hashtags include only letters/digits/underscore and exclude punctuation or spaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR fixes a bug where hashtags located in the middle of a sentence were incorrectly linked because the application captured trailing spaces and punctuation as part of the hashtag name.
1. Reproduction Steps
To confirm the bug, I performed the following:
Swiz: "Let's get some #SwizBiz love!!"http://localhost:3000/hashtag/SwizBiz%2520love!!.2. The Problem
Hashtags located in the middle of a sentence were being "over-captured." Because the link included spaces and punctuation, the backend could not find a match in the database, resulting in an empty results page.
3. The Discovery
I investigated
frontend/components/bloom.mjsand found the_formatHashtagsfunction./\B#[^#]+/g.[^#]+part tells the browser to "capture every character that is NOT a hash." Since spaces and exclamation marks are not hashes, the browser kept grabbing them until the end of the string.4. The Fix
I updated the Regex pattern in
frontend/components/bloom.mjsto:/\B#\w+/g5. The Logic
By switching to
\w+, the Regex is now restricted to "Word Characters" (letters, numbers, and underscores).6. Verification
After the fix, I returned to the timeline and clicked the same link.
#SwizBiz./hashtag/SwizBiz.