Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Bug Report: Hashtag link doesn't work correctly#144
Closed
RahwaZeslusHaile wants to merge 0 commit into
Closed
Conversation
OracPrime
suggested changes
Mar 13, 2026
OracPrime
left a comment
There was a problem hiding this comment.
The bloom.mjs change is good, but the rest need removing
| if (!text) return text; | ||
| return text.replace( | ||
| /\B#[^#]+/g, | ||
| /#\w+/g, |
There was a problem hiding this comment.
I think the changes in this file are the only ones we're expecting in this PR. You should revert the other files (if you changes to make something work on your local machine, you shouldn't push them to git unless it is an authorised part of the change)
afb9133 to
988083c
Compare
e7e21c6 to
b2dcd10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Bug Report: Hashtag link doesn't work correctly
Learners, PR Template
Self checklist
Fix: Hashtag Links Not Working Properly
Description
This PR fixes an issue where hashtag links in blooms weren't working consistently. Specifically, clicking on hashtags like
#SwizBizin some blooms would take you to an empty hashtag page with no results, while clicking the same hashtag in other blooms would work correctly.Root Cause
The hashtag regex in the frontend was using
/\B#[^#]+/g, which has issues with word boundaries and special characters. This caused inconsistent hashtag link generation depending on the context in which the hashtag appeared.Changes
/\B#[^#]+/gto/#\w+/g#followed by word charactersHow to Test
#SwizBizin "Let's get some #SwizBiz love!!"#SwizBizin other blooms and verify consistent behaviorRelated Issue
Resolves weird hashtag link behavior where the same hashtag would work in some blooms but not others.
Please review my work — thank you!