London_Class10-Jan_Softa-Module-Week1-4#600
Open
softacoder wants to merge 20 commits into
Open
Conversation
second update
Started over with new coding.
Changed written code from 2st versions
Belongs to week 1
Both Menu and ham-menu works to link to store page
It calls from media request from the media.css
Elenar9
reviewed
Feb 17, 2023
| display: block; | ||
| padding: 12px 24px; | ||
|
|
||
| color: #333; |
nsaimk
reviewed
Feb 17, 2023
| </label> | ||
|
|
||
| <ul class="menu__box"> | ||
| <li><a class="menu__item" href="Meet Karma">Meet Karma</a></li> |
There was a problem hiding this comment.
Suggested change
| <li><a class="menu__item" href="Meet Karma">Meet Karma</a></li> | |
| <li><a class="menu__item" href="Meet Karma"><strong>Meet Karma</strong></a></li> |
Author
There was a problem hiding this comment.
I added you by mistake the second time. Thanks anyway! I would probably choose bold instead of strong. I am not sure what strong does. I will test it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?