London Turing - Zahraa Tayyar - HTML/ CSS 1 - Week 2#530
Open
zahraateee wants to merge 21 commits into
Open
Conversation
Started off the page
second section of front page nearly finished
inserted footer
Made updates to the general layout of the page
Fixed the issue with the sizes of the icons, and aligned the page properly
Added the feature section
Started working on html of store page
developed css
updated CSS of the store page to allow it to match layout. Had trouble aligning form. linked navigation bar with their respective "home" and "store" pages.
alexanderkhivrych
approved these changes
Nov 5, 2022
alexanderkhivrych
left a comment
There was a problem hiding this comment.
Well done. I like that you are started using Bem naming https://getbem.com/naming/
fixed header issue. to fix: 1. logo disappeared from header. 2. radio buttons taking up too much space 3. checkmark box too big and right-aligned 4. main site image taking up too much space
colour change on footer when mouse hovers over icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy? using vscode and github
What did you find hard? starting html from scratch and figuring out sections
What do you still not understand? how to fix icon sizes and making them same size in a row
Any other notes?
View rendered .github/pull_request_template.md