manchester_class5_yousef shaikhan_html/css_ week1#473
Open
youweb3 wants to merge 2 commits into
Open
Conversation
| font-family: 'Roboto', sans-serif; | ||
| -webkit-font-smoothing: antialiased; | ||
|
|
||
| margin: 0.5rem 1rem; |
There was a problem hiding this comment.
margin:0.5 em 1em;
it s better to use em foe margin and padding
Author
There was a problem hiding this comment.
Thank you for reviewing my cod.
luan-murilo-de-oliveira-e-souza
left a comment
There was a problem hiding this comment.
review completed
| @@ -0,0 +1,136 @@ | |||
| body { | |||
There was a problem hiding this comment.
You can use the same CSS file to style your HTML files because many styles are for both files.
| margin-bottom: 60px; | ||
| } | ||
|
|
||
| .homepage-extended{ |
There was a problem hiding this comment.
You could have used grid here, it would be easier.
| <!-- Add your HTML markup here --> | ||
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
| <!-- All the images you need are in the 'img' folder --> | ||
|
|
There was a problem hiding this comment.
You can pass your code at https://validator.w3.org/
Author
There was a problem hiding this comment.
Thanks for reviewing my cod and mentioning what should I do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard? FLEX BOX
What do you still not understand? DIRECTION FLEX BOD/ NAV BAR
Any other notes?