leeds-JihadOmer-html-css-week1#472
Open
JihadOmer wants to merge 6 commits into
Open
Conversation
Author
|
finished |
levilu800b
suggested changes
Aug 10, 2022
levilu800b
left a comment
There was a problem hiding this comment.
You did a good job with your Karma project however you should think about how you add the images to the websites you are developing.
|
|
||
| <img class="form-image" src="../HTML-CSS-Module- Karma-Project/level-2/store-image_by-andrew-neel-unsplash.jpg" alt=""> | ||
|
|
||
| <img src="https://images.unsplash.com/photo-1535957998253-26ae1ef29506?ixlib=rb-1.2.1&ixid=MnwxMjA3fDB8MHxzZWFyY2h8Nnx8b2ZmaWNlfGVufDB8fDB8fA%3D%3D&auto=format&fit=crop&w=500&q=60" alt="store image"> |
There was a problem hiding this comment.
You should consider downloading the image rather than using the link because the image could be removed from the link could be removed from the web or wherever you got it from. The reason why is, if the link is removed from the web or where you got it the image can't be viewed on your site anymore.
Meronggk
suggested changes
Aug 10, 2022
Meronggk
left a comment
There was a problem hiding this comment.
you could use nav tag for the navigation
| <a href="#">Blog</a> | ||
| <a href="#">Help</a> | ||
| <a href="#">Login</a> | ||
|
|
There was a problem hiding this comment.
you could use nav tag for the navigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?