NW Class 5 - Khesiwe Dube- HTML/CSS - Week 1 Karma project #468
NW Class 5 - Khesiwe Dube- HTML/CSS - Week 1 Karma project #468KhesiweDube wants to merge 3 commits into
Conversation
|
Hi Khesiwe! Did notice a couple genral things as well as a few code specfic things (which I'll comment seprately below)
|
| </ul> | ||
| </header> | ||
| <main class="store-main"> | ||
| <fieldset> |
There was a problem hiding this comment.
fieldset is normally used for grouping radio buttons to make clear they are related for accessability, rather than for the full form See https://syllabus.codeyourfuture.io/html-css/week-2/lesson#radio-input-fields https://developer.mozilla.org/en-US/docs/Web/HTML/Element/fieldset
| </div> | ||
| <div class="term"> | ||
| By placing an order you agree to Karma's <a class="terms" href="https://example.com">Terms and Conditions</a> | ||
| <label for=""></label> |
There was a problem hiding this comment.
You've used labels throughout which is brillant but the spec on the assignment does ask for validation on the form fields as well see https://syllabus.codeyourfuture.io/html-css/week-2/lesson#form-validation
| <div> | ||
| <button>Place my order</button> | ||
| </div> | ||
| </form> |
|
|
||
| } | ||
| h1 { | ||
| margin-top: 50px; |
There was a problem hiding this comment.
It's best to use rem or em units when possible :)
| .store { | ||
| color: #DE6E49; | ||
| } | ||
| input[type="text"], input[type="number"], select { display: block; padding: 7px; border: 2px solid #efefef; |
There was a problem hiding this comment.
This is a clever CSS selector! Good work
The title for your pull request should be made in this format
Your Name: Khesiwe Dube
Your City: NW5 Manchester
Your Slack Name: Khesiwe Dube
Module: 2
Week: 2
What did you find easy? creating nav tag and CSS
What did you find hard? some css sizing
What do you still not understand? some CSSand some tags
Any other notes?