Skip to content

Finish HTML-CSS-Module-Project#458

Open
Danti8686 wants to merge 3 commits into
CodeYourFuture:masterfrom
Danti8686:master
Open

Finish HTML-CSS-Module-Project#458
Danti8686 wants to merge 3 commits into
CodeYourFuture:masterfrom
Danti8686:master

Conversation

@Danti8686
Copy link
Copy Markdown

@Danti8686 Danti8686 commented Jul 28, 2022

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name: Ahmed Mahmoud
  • Your City: Manchester
  • Your Slack Name: Danti

Homework Details

  • Module: Html-CSS module-box
  • Week: W2

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?

@Danti8686
Copy link
Copy Markdown
Author

It was really hard week for me

Copy link
Copy Markdown

@yogaraptor yogaraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 There's a lot of comments/suggestions here because I've reviewed week 1 and week 2 at the same time - please feel free to reach out to chat through any of this in-person if you need to.

There are a few discrepancies between the Figma designs (main page, store page), but as I wasn't in class on Saturday I'm not sure whether these are deliberate. Have a quick look over your page and compare it to the designs and make sure you're happy with:

  • Font sizes and faces (for example the store page doesn't seem to be using the Roboto font)
  • Button styles (make sure you're removing the raised border and other default styles - here's a good recipe for that)
  • Layout (e.g. gaps between social icons in the footer)

Comment thread css/danti.html
<img src="../level-2/store-image_by-andrew-neel-unsplash.jpg" alt="">
</div>

<!-- <div class="form">form</div> -->
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread index.html
</main>
<main class="three_imgs">
<div class="img_device img_1">
<img src="img\icon-devices.svg" alt="icon devices">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="img\icon-devices.svg" alt="icon devices">
<img src="img/icon-devices.svg" alt="icon devices">

While most browsers will handle a back slash (\) as a separator in URLs, it's convention to use a forward slash /.

Comment thread index.html
Comment on lines +73 to +85
<!-- <header class="header">

<img class="img1" src="favicon.ico"/>
<a href="#">Meet Karma</a>
<a href="#">How it Works</a>
<a href="#">Store</a>
<a href="#">Blog</a>
<a href="#">Help</a>
<a href="#">Login</a>

<div>
<img src="first-background.jpg"/>
</div> -->
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this commented out code as you're no longer using it. You can always see the history of this file in Git if you need to. Alternatively, if you want to keep it around, consider storing it in a separate file outside of your repo. See https://syllabus.codeyourfuture.io/guides/code-style-guide#dont-leave-lots-of-commented-out-code for more info

Comment thread index.html
<img src="first-background.jpg"/>
</div> -->

</header>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you missed this closing tag when commenting out the block above - it can be removed along with the commented out code.

As an extra note, this extra closing tag affects the validity of the HTML page. Browsers are usually quite forgiving, and this probably won't cause any visual or functional issues with your page, but it will stop Prettier from formatting your code - Prettier can only format your code if it is valid. If you remove this closing tag and then run the "format document" command in VSCode with this file open then you'll see several changes occur, like extra spaces being removed, indentation changed, etc. You can run the format document command with ctrl + shift + p (or cmd + shift + p if you're using a Mac), then type format document and hit enter. If you've set up VSCode as described here then this should happen automatically when you save your code.

Comment thread css/danti.html
@@ -0,0 +1,127 @@
<!DOCTYPE html>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The css folder should contain css files only - you can keep this HTML file in the root of the project, along with index.html.

I'd also suggest naming danti.css and danti.html store.css and store.html to make it obvious what they provide 👍

Comment thread css/danti.css
@@ -0,0 +1,306 @@
.contener{
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do follow my other comment and include style.css on the store page, be aware that you have a rulset in that CSS file for .contener as well. If you want them to do different things, you'll need to give them different class names.

Comment thread index.html
<!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc -->
<!-- All the images you need are in the 'img' folder -->

<main>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's usually only one <main> element on the page, used for the primary content area. There are several other semantic elements you could use to "section" your content. This part of the week 1 lesson should have everything you need 🚀

Comment thread css/danti.html

<div class="contener">
<div class="nav_all">
<img class="icon_nav_p2" src="../img/karma-logo.svg"/>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember every image need an alt attribute which should attempt to provide equivalent meaning for users of screen-readers and other assistive technologies. In this case, it's a logo, so useful alt text would be the name of the company, Karma.

Comment thread index.html
<nav class="nav_ul">
<a href="#">Meet Karma</a>
<a href="#">How it Works</a>
<a href="#">Store</a>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You linked the button in the new page section to the store page, just need to update this item to link to the store as well 👍

Comment thread index.html
</main>
<main class="main_back_img">
<div class="ad_back_img">
<h3>introducing Karma</h3>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a h2, because there's no h2 for this to be a sub-heading of. See https://syllabus.codeyourfuture.io/html-css/week-1/lesson#text-content

The h4 below probably doesn't need to be a heading at all - it can be a paragraph (<p>) or <span> and you can style it to be the right font size, etc.

See https://www.w3schools.com/html/html_headings.asp for an overview of how and when to use headings, and why it's important to only use them when the text really is a heading (and not just "big text").

Comment thread index.html
Comment on lines +23 to +30
<nav class="nav_ul">
<a href="#">Meet Karma</a>
<a href="#">How it Works</a>
<a href="#">Store</a>
<a href="#">Blog</a>
<a href="#">Help</a>
<a href="#">Login</a>
</nav>
Copy link
Copy Markdown

@yogaraptor yogaraptor Aug 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice accessibility pattern for navigation menus is to use a list within the <nav> element:

Suggested change
<nav class="nav_ul">
<a href="#">Meet Karma</a>
<a href="#">How it Works</a>
<a href="#">Store</a>
<a href="#">Blog</a>
<a href="#">Help</a>
<a href="#">Login</a>
</nav>
<nav class="nav_ul">
<ul>
<li><a href="#">Meet Karma</a></li>
<li><a href="#">How it Works</a></li>
<li><a href="#">Store</a></li>
<li><a href="#">Blog</a></li>
<li><a href="#">Help</a></li>
<li><a href="#">Login</a></li>
</ul>
</nav>

you can add rules in your CSS file to remove the default browser "bullet point" styles like this:

.nav_ul ul {
  margin: 0;
  padding: 0;
  list-style: none;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants