Skip to content

NW5-Leeds-Meron Gebremichael-HTML/CSS-week 1#447

Open
Meronggk wants to merge 10 commits into
CodeYourFuture:masterfrom
Meronggk:master
Open

NW5-Leeds-Meron Gebremichael-HTML/CSS-week 1#447
Meronggk wants to merge 10 commits into
CodeYourFuture:masterfrom
Meronggk:master

Conversation

@Meronggk
Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name: Meron
  • Your City: Sheffield
  • Your Slack Name: Meron Gebremichael

Homework Details

  • Module: HTML/CSS
  • Week: 1

Notes

  • What did you find easy?
    uploading the images
  • What did you find hard?
    CSS
  • What do you still not understand?
    some part of CSS
  • Any other notes?
    not really

Comment thread index.html
@@ -1,19 +1,99 @@
<!DOCTYPE html>
<html lang="en">
<header></header>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove this because it is useless

Comment thread index.html
<main>
<section>

</body>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it extra tage

Comment thread index.html
<section>

</body>
</html>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra tag

Copy link
Copy Markdown

@levilu800b levilu800b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the code and try fixing it.

Comment thread store.html
<label for="inputZip" class="form-label">Postcode*</label>
<input type="text" class="form-control" id="inputZip">
</div>
<div class="radios">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should style the radio and checkbox to work properly with the colour in the Figma design.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants