Skip to content

West Midlands Class 4 - Saadia el fekak - HTML/CSS - Week 1#396

Open
SaadiaELF wants to merge 14 commits into
CodeYourFuture:masterfrom
SaadiaELF:master
Open

West Midlands Class 4 - Saadia el fekak - HTML/CSS - Week 1#396
SaadiaELF wants to merge 14 commits into
CodeYourFuture:masterfrom
SaadiaELF:master

Conversation

@SaadiaELF
Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name: Saadia El fekak
  • Your City: West Midlands
  • Your Slack Name: SaadiaELF

Homework Details

  • Module: HTML/CSS
  • Week: 1

Notes

  • What did you find easy?
    Implementing semantics and using CSS variables
  • What did you find hard?
  1. Trying to rebuild the exact website, especially the same font size, padding and margins
  2. Changing the image border without affecting the image (I think we need to use a wrap around the image)
  • What do you still not understand?
    About the folders "level 2" and "level 3". It wasn't clear if they are included as a bonus or if they'll be done as an upcoming homework.
  • Any other notes?

Comment thread css/style.css
padding: 1rem;
border: 1px solid var(--grey-light);
border-radius: 50%;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats good Saadia, I had the problem with icons and i checked yours .css file, This is my opinion, you will be good developer, please go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants