West Midlands Class 4 - Saadia el fekak - HTML/CSS - Week 1#396
Open
SaadiaELF wants to merge 14 commits into
Open
West Midlands Class 4 - Saadia el fekak - HTML/CSS - Week 1#396SaadiaELF wants to merge 14 commits into
SaadiaELF wants to merge 14 commits into
Conversation
ozibozkurt
reviewed
Jul 20, 2022
| padding: 1rem; | ||
| border: 1px solid var(--grey-light); | ||
| border-radius: 50%; | ||
| } |
There was a problem hiding this comment.
Thats good Saadia, I had the problem with icons and i checked yours .css file, This is my opinion, you will be good developer, please go ahead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
Implementing semantics and using CSS variables
About the folders "level 2" and "level 3". It wasn't clear if they are included as a bonus or if they'll be done as an upcoming homework.