Skip to content

ZA2-Anthony Mogotlane-HTML/CSS Module Project-W3#366

Open
AnthonyMogotlane wants to merge 8 commits into
CodeYourFuture:masterfrom
AnthonyMogotlane:master
Open

ZA2-Anthony Mogotlane-HTML/CSS Module Project-W3#366
AnthonyMogotlane wants to merge 8 commits into
CodeYourFuture:masterfrom
AnthonyMogotlane:master

Conversation

@AnthonyMogotlane
Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name:
  • Your City:
  • Your Slack Name:

Homework Details

  • Module:
  • Week:

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?

Copy link
Copy Markdown

@TemwaNyirenda TemwaNyirenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Your website is near perfect, everything almost the same as the original. Other than the colour of the button, I see no issues

Comment thread css/style.css
.learn-btn {
margin-top: 2.5em;
padding: .45em;
background: rgb(216, 142, 5);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This button should be orange (rgb(224,99,58)), yours is yellow.
Suggestion: There's a Chrome extension, Eye Dropper, it can help to pick up colours off of webpages.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will take a look on that.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will take a look on that.

Comment thread css/style.css
.footer>p {
color: grey;
text-align: center;
} No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anthony besides the button color it all look very good well done.

Comment thread index.html
<button class="learn-btn">Learn More</button>
</section>

<main class="main">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anthony your layout is very neat, just maybe try using more descriptive names for your class.

@tersiakoetzee
Copy link
Copy Markdown

Very nicely done Anthony

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants