Skip to content

ZA2 Matthias Matanda-Karma-week2 #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mathias02 wants to merge 7 commits into
base: master
Choose a base branch
from
Open

ZA2 Matthias Matanda-Karma-week2 #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a8a2030
first commit
Mathias02 Jun 13, 2022
8b9efdc
main section added
Mathias02 Jun 13, 2022
1dd1414
footer element added to the website
Mathias02 Jun 13, 2022
c3966ab
comment added in html
Mathias02 Jun 13, 2022
3125661
add attribute content
Mathias02 Jun 17, 2022
7062a35
alt attribute for img changed
Mathias02 Jun 18, 2022
915c224
Merge branch 'master' of https://github.com/Mathias02/HTML-CSS-Module…
Mathias02 Jun 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
215 changes: 214 additions & 1 deletion css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@
body {
font-family: 'Roboto', sans-serif;
-webkit-font-smoothing: antialiased;
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
overflow-x: hidden;
}

/**
* Add your custom styles below
*
Expand All @@ -16,4 +20,213 @@ body {
* - When using Flexbox, remember the items you want to move around need to be inside a parent container set to 'display: flex'
*/

/****General styles****/
*, ::before, ::after {
margin: 0;
padding: 0;
box-sizing: border-box;
}

ul{
list-style: none;
}
a{
text-decoration: none;
}

/*************************************header styles *********************************************/

header{
display: grid;
grid-template-areas:
'lgo lgo alist alist';
width: 100%;
height: 40px;
color: #060505;
margin: 0 auto 20px auto;
}
header .logo{

@Riyaazct Riyaazct Jun 17, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 48 & 57 is a duplicate selector.

grid-area: lgo;

}
header .list{
grid-area: alist;

}

header .logo {
display: flex;
justify-content: flex-start;
padding-left: 5rem;
align-items: center;
}

header .logo img{
max-width: 25px;
object-fit: cover;
line-height: 40px;
}

header .list{
padding: 1px;
}
.list ul {
display: flex;
justify-content: center;
line-height: 40px;

}
.list ul li{
margin: 10px;
}

.list ul li:nth-child(2){
color: rgba(170, 170, 170,.9);
}

.list ul li a{
text-align: center;
text-transform: capitalize;
padding: .5rem;
color: rgba(170, 170, 170,.6);
}
.list ul li a:hover{
color: #ee0707;
}

/************************************main styles*****************************************/
main{
width: 100vw;
display: flex;
justify-content: center;
align-items: center;
}

main .karma {
position: relative;
width: 100vw;
}

main .karma img{
width: 100%;
object-fit: cover;
}
main .details {
position: absolute;
top: 50%;
left: 52%;
display: flex;
flex-direction: column;
align-items: center;
letter-spacing: 1.5px;
color: aliceblue;
transform: translate(-50%, -50%);

}

.details h1{
font-weight: 100;
font-size: 2.5rem;
text-transform: capitalize;
}

.details p{
font-weight: 100;
font-size: 1.3rem;
margin-bottom: 2rem;
}

.details button{
color: #fdf8f8;
text-align: center;
padding: 10px 20px;
outline: none;
text-transform: capitalize;
border: 1px solid coral;
background: coral;
border-radius: 3px;
}

/*********************************section styles********************************/

section{
width: 100vw;
display: flex;
flex-direction: column;
align-items: center;
margin-bottom: 1rem;
justify-content: center;
}

section .karma1 {
flex: 1;
padding: 10px;
width: 100vw;
}

.karma1 h1 {
text-align: center;
letter-spacing: 2.3px;
font-size: 2.5rem;
font-weight: 90;
color: #2e2c2c;
}

.karma-img{
display: flex;
justify-content: space-around;
align-items: center;
padding: 1rem;
}

.karma-img div{
width: 14rem;
}

.karma-img p{
margin: 10px;
font-size: 1.2rem;
font-weight: 400;
}

/****************************************footer styles****************************************/

footer {
width: 100vw;
height: 350px;
display: flex;
flex-direction: column;
align-items: center;
margin-top: 1rem;
padding: 2rem 1rem;
border-top: 1px solid rgba(195, 194, 194,.5);
}
footer h4 {
font-weight: 200;
margin: 1rem;
}

footer .links {
margin: 1rem;
width: 15%;
padding: 5px;
text-align: center;
}
.links a {
width: 10%;
padding: .555rem;
}
.links a img {
width: 25px;
height: 25px;
padding: 2px;
border-radius: 50%;
border: 1px solid rgba(196, 196, 196, .4);
display: inline-block;
}

footer h5{
color: #c6c6c6;
font-weight: 300;
letter-spacing: 1.5px;
}
58 changes: 58 additions & 0 deletions index.html
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,64 @@
<!-- Add your HTML markup here -->
<!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc -->
<!-- All the images you need are in the 'img' folder -->
<!------------------------------------header------------------------------>
<header>
<div class="logo">
<img src="img/karma-logo.svg" id="left-logo" alt="logo photo">
</div>
<div class="list">
<ul>
<li>Meet Karma</li>
<li>How it works</li>
<li><a href="#">store</a></li>
<li><a href="#">blog</a></li>
<li><a href="#">help</a></li>
<li><a href="#">login</a></li>
</ul>
</div>
</header>
<!-----------------------------------main area------------------------------>
<main>
<div class="karma">
<img src="img/first-background.jpg" alt="background photo">
<div class="details">
<h1>introducing karma</h1>
<p>Bring WIFI with you, everywhere you go.</p>
<button>learn more</button>
</div>
</div>
</main>
<!------------------------------------section-------------------------------->

@Riyaazct Riyaazct Jun 17, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done Mathias, code is easy to navigate and commenting looks good.
One thing you can look into though, the main content of a webpage goes within the main tags, so your sections from line 46 to 65 would normally also be part of the main element.

@Mathias02 Mathias02 Jun 17, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but I preferred to keep it in a section than setting it in the main area, thanks for seeing that

<section>
<article class="karma1">
<h1>Everyone needs a little Karma.</h1>
<div class="karma-img">
<div>
<img src="img/icon-devices.svg" alt=" device photo">
<p>Internet for all devices</p>
</div>
<div>
<img src="img/icon-coffee.svg" alt="coffee photo">
<p>Boost your productivity</p>
</div>
<div>
<img src="img/icon-refill.svg" alt="refill photo">
<p>Pay as You Go</p>
</div>
</div>

</article>
</section>
<!----------------------------------------footer------------------------------------------>
<footer>
<h4>Join us on</h4>
<div class="links">
<a href="#"><img src="img/twitter-icon.svg" alt="twitter photo"></a>
<a href="#"><img src="img/facebook-icon.svg" alt="facebook photo"></a>
<a href="#"><img src="img/instagram-icon.svg" alt="instagram photo"></a>
</div>
<h5>&copy; karma mobility.inc</h5>
</footer>
Comment thread
Mathias02 marked this conversation as resolved.
</body>
</html>